Skip to content

Conversation

@marmarek
Copy link
Member

Glib >= 3.50 has native asyncio integration. When available, use it
instead of gbulb.
This requires few minor changes:

  • asyncio.run() doesn't work there (asyncio.set_event_loop() cannot be
    called on the main thread with glib...)
  • there is no gbulb.wait_signal() anymore - implement it manually

Based on #191 by
@CertainLach

QubesOS/qubes-issues#9809

@qubesos-bot
Copy link

qubesos-bot commented May 27, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025052900-4.3-fedora&flavor=templates

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

  • system_tests_whonix
    • whonix_torbrowser: unnamed test (unknown)
    • whonix_torbrowser: Failed (test died)
      # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...

Failed tests

2 failures
  • system_tests_whonix
    • whonix_torbrowser: unnamed test (unknown)
    • whonix_torbrowser: Failed (test died)
      # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

5 fixed

Unstable tests

  • system_tests_update

    update2/Failed (1/5 times with errors)
    • job 139051 # Test died: command 'script -c 'qubes-vm-update --force-update --l...

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

This was referenced May 27, 2025
Glib >= 3.50 has native asyncio integration. When available, use it
instead of gbulb.
This requires few minor changes:
- asyncio.run() doesn't work there (asyncio.set_event_loop() cannot be
  called on the main thread with glib...)
- there is no gbulb.wait_signal() anymore - implement it manually

Based on QubesOS#191 by
@CertainLach

QubesOS/qubes-issues#9809
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.90%. Comparing base (fc01331) to head (845750a).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
qrexec/tools/qrexec_policy_agent.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   79.01%   78.90%   -0.12%     
==========================================
  Files          55       55              
  Lines       10508    10519      +11     
==========================================
- Hits         8303     8300       -3     
- Misses       2205     2219      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marmarek marmarek merged commit 16944a3 into QubesOS:main May 30, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants