Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] qwik-city: vite base doesn't work in dev mode #5984

Closed
wmertens opened this issue Mar 9, 2024 · 8 comments
Closed

[🐞] qwik-city: vite base doesn't work in dev mode #5984

wmertens opened this issue Mar 9, 2024 · 8 comments
Labels
COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: qwik-city TYPE: bug Something isn't working

Comments

@wmertens
Copy link
Member

wmertens commented Mar 9, 2024

Which component is affected?

Qwik City (routing)

Describe the bug

When you set config.base of vite, the build correctly uses it but dev mode breaks, getting module files without the base path.

Reproduction

https://stackblitz.com/edit/qwik-starter-wvwual?file=vite.config.ts

Steps to reproduce

try clicking Home

System Info

stackblitz, 1.5.1

Additional Information

No response

@wmertens wmertens added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged COMMUNITY: good first issue Good for newcomers COMP: qwik-city COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it P1: nice to have / fix and removed STATUS-1: needs triage New issue which needs to be triaged labels Mar 9, 2024
@wmertens
Copy link
Member Author

wmertens commented Mar 9, 2024

Workaround: In your vite config, use

export default defineConfig(({command, mode}) => {
	return {
		base: command === 'build' ? '/your-base/' : undefined,
// ...

@JerryWu1234
Copy link
Contributor

let me pick this up.,

@JerryWu1234
Copy link
Contributor

image
you say this bug ?

@wmertens
Copy link
Member Author

@JerryWu1234 yes it should use the import.meta.env.BASE_URL in front of it

@JuanmaVargas
Copy link

In production, is there any workaround to fix this? I'm trying to create a multi-zone in Next.js for a Qwik application, and for that, I need the vite.base set in the configuration to work for all the assets

@wmertens
Copy link
Member Author

wmertens commented Jun 4, 2024

@JuanmaVargas do you mean it's not working in production?

I have the fix for dev in #6326 but it's part of a rewrite. I hope to land it soon.

@JohnPremKumar
Copy link
Contributor

Meantime if anyone looking for workaround set different path production and development:

export default defineConfig(() => {
  return {
    base: process.env.NODE_ENV === 'production' ? `/production-path/` : '',
    plugins: [
      qwikCity(),
      qwikVite(),
      tsconfigPaths(),
      vanillaExtractPlugin(),
    ],
  };
});

@wmertens
Copy link
Member Author

I believe this to be fixed in 1.7.1. There are still some problems with windows though, see #6676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: qwik-city TYPE: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants