refactor: Add S7_error_validation classes (fixes #602)#605
Merged
hadley merged 7 commits intoRConsortium:mainfrom Apr 21, 2026
Merged
Conversation
Replace stop(msg, call. = FALSE) with stop(errorCondition(...)) in validate() so property-type and custom-validator errors carry subclasses S7_error_validation_property and S7_error_validation_object (both inheriting from S7_error_validation), making them catchable via tryCatch() without parsing message strings.
This reverts commit 1975a6f.
hadley
reviewed
Apr 12, 2026
Member
|
I think it would be good to document these, but it's not clear to me where to put that documentation such that folks are likely to find it. |
Member
|
Can you please add a bullet to the top of |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #602
todo: