Skip to content

Commit 3ec62a2

Browse files
bors[bot]gschorcht
andauthored
Merge #19797
19797: Makefile.include: don't use target lstfile implicitly r=maribu a=gschorcht ### Contribution description This PR reverts a part of PR #19745. It removes the `$(LSTFILE)` from the `BUILD_FILES` variable so that the `.lst` file isn't generated implicitly. If the `.lst` file is needed, it can be generated with `lstfile` target. **Background** The compilation time increased a lot with PR #19745. The reason is that the generation of the `.lst` file seems to be time-consuming. For example, on an Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz` with 8 cores and a SSD, it takes about 15 seconds for a complex application such as `tests/sys/usbus_msc` for a STM32F7 MCU. Therefore, the compilation time for ``` BOARD=stm32f723e-disco make -j8 -C tests/sys/usbus_msc ``` increased from about 1 sec to about 16 seconds (all source files were already compiled). Even for a small application ``` BOARD=stm32f723e-disco make -j8 -C tests/sys/shell ``` the compilation time increased from about 1 sec to about 10 seconds. ### Testing procedure Green CI ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>
2 parents 9d59673 + 1d96feb commit 3ec62a2

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

Makefile.include

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -693,15 +693,6 @@ endif
693693

694694
BUILD_FILES += $(ELFFILE) $(BINFILE) $(FLASHFILE) $(HASHFILE)
695695

696-
# when not in CI, aid developers in debugging the firmware with a full memory
697-
# layout and disassembly provided by the lst file:
698-
ifneq ($(RIOT_CI_BUILD),1)
699-
# as of now, the xtensa tools cannot create lst files
700-
ifeq (,$(findstring xtensa,$(PREFIX)))
701-
BUILD_FILES += $(LSTFILE)
702-
endif
703-
endif
704-
705696
# variables used to compile and link c++
706697
ifneq (,$(filter cpp,$(USEMODULE)))
707698
CPPMIX ?= 1

0 commit comments

Comments
 (0)