sys/psa_crypto: chacha20 multipart operation implementation [Rebase] #21927
+1,300
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reallxo
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
github-actions
bot
added
Area: tests
AnnsAnns
added
the
CI: ready for build
Member
|
It sounds like nothing was changed aside from rebasing it and from the looks of it you were ready for the final review in the original PR @mguetschow, is that still correct? |
AnnsAnns
requested changes
Dec 3, 2025
Member
AnnsAnns
left a comment
AnnsAnns
left a comment
There was a problem hiding this comment.
Thank you for your work on getting this merged again 😄
I did not look at the implementation itself, however, here are some nitpicks that have changed since the original PR was made. Also, please take a look at the static test output for a lot of complaints it has such as whitespaces, empty lines and long lines.
There are also a lot of todos left in multiple files, are these all still valid / are you addressing them in this PR?
AnnsAnns
changed the title
publicvoid1337
force-pushed
the
rebase-psa-cipher-chacha20-multipart-operation-implementation
branch
from
789c8b8 to
c04816e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This pull request updates the former pull request “PSA cipher ChaCha20 multipart operation implementation” (#20788) by @Wunderbaeumchen99817 to the current state of the master branch.
The original changes have been rebased and split up into multiple commits to ensure clarity and make the review process easier.
The goal of this PR is to bring the previous contribution up to date and into a reviewable and maintainable form and request reviews from supervisors.
Testing procedure
TBD
Issues/PRs references
original pull request
Psa cipher chacha20 multipart operation implementation #20788
#20788