fix(monitoring): remove --pid host, consolidate cpu smoke test into c… - #111
Open
sbates130272 wants to merge 1 commit into
Open
fix(monitoring): remove --pid host, consolidate cpu smoke test into c…#111sbates130272 wants to merge 1 commit into
sbates130272 wants to merge 1 commit into
Conversation
…ompose spur-authz blocks --pid=host on all SPUR nodes. The cpu smoke test was using raw docker run with --pid host for node-exporter and nvme-exporter, causing a fatal exit 125. The monitoring compose had the same flag, which has been silently failing in all CI tests where monitoring is best-effort. - Remove pid: host from node-exporter and nvme-exporter in docker-compose.monitoring.yml; hsa-snoop retains it (kprobe requirement) - Add exporters-cpu profile covering node/nvme/rdma but not GPU exporters (amdgpu-exporter, hsa-snoop), so the cpu smoke test can use start_monitoring() without attempting to launch GPU-only services - Switch docker-compose.emulator.yml from bridge+published port to network_mode: host, consistent with the monitoring stack's localhost scraping - Rewrite spur-monitoring-cpu-smoke.sh SRUN_BODY to use compose + monitoring-lib.sh (start_monitoring/stop_monitoring) instead of reimplementing container orchestration inline with raw docker run - Add AIC_CPU_SMOKE=1 flag to mon_profile() in monitoring-lib.sh to select the exporters-cpu profile; add aic-vllm-emulator to MON_CONTAINERS Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Stephen Bates <sbates@raithlin.com>
sbates130272
requested review from
amd-ivaganev,
gaoikawa and
vcave
as code owners
July 29, 2026 19:56
Collaborator
Author
|
/run-ci |
Collaborator
|
IIRC |
|
✅ Hardware CI passed for f7d9244 (dist-build + smoke-test + tiny-test). |
Collaborator
Author
It seems that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ompose
spur-authz blocks --pid=host on all SPUR nodes. The cpu smoke test was using raw docker run with --pid host for node-exporter and nvme-exporter, causing a fatal exit 125. The monitoring compose had the same flag, which has been silently failing in all CI tests where monitoring is best-effort.