Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent use of ffmax / ffmin #77

Closed
webepasc opened this issue Apr 26, 2019 · 0 comments · Fixed by RayTracing/TheNextWeek#43
Closed

consistent use of ffmax / ffmin #77

webepasc opened this issue Apr 26, 2019 · 0 comments · Fixed by RayTracing/TheNextWeek#43
Assignees
@trevordblack
Labels
book 2: Next Week

Comments

@webepasc
Copy link

Although the use of ffmax and ffmin is advertised, for aabb surrounding_box(aabb box0, aabb box1) the functions fmax and fmin from the <math> library are used.
@trevordblack trevordblack self-assigned this Aug 17, 2019
trevordblack referenced this issue in RayTracing/TheNextWeek Aug 20, 2019
@trevordblack
Replaced fmax and fmin with ffmax and ffmin within the src and the bo…
6f1a401 
…ok. Closes #9
@hollasch hollasch transferred this issue from RayTracing/TheNextWeek Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevordblack trevordblack

Labels
book 2: Next Week
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced fmax and fmin with ffmax and ffmin within the src and the bo… RayTracing/TheNextWeek
3 participants
@hollasch @trevordblack @webepasc