bug(YouTube - Hide layout components): 'Hide horizontal shelves' hides music and game links in video descriptions

[yonggamer]

Bug description

with Hide layout components patch

with Hide layout components patch.txt

without Hide layout components patch

without Hide layout components patch.txt

Error logs

Solution

No response

Additional context

ReVanced Manager: 1.24.0
Model: SM-G965F
Android version: 10
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[oSumAtrIX]

The patch adds toggles to the app, which one causes it to hide?

[yonggamer]

[LisoUseInAIKyrios]

@yonggamer include hide layout components patch, then turn off hide settings until you find which individual setting causes the issue.

[yonggamer]

@LisoUseInAIKyrios looks like this is the problem

[ILoveOpenSourceApplications]

Must be an A/B testing. I can replicate this in one of my account but not in the other.

04-04 20:13:07.295 28669 28669 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_shelf.eml|5eff32bb752d0020|CellType|horizontal_shelf_content.eml|b5b4b6f6ed66642b|ContainerType|ContainerType| BufferStrings: button.eml|fdca390897fbe814❙cell_video_attribute.eml|9e0c687c5bdc2f0❙Ne$H❙horizontal_shelf_content.shelf_header❙shelf_header.eml|ba6ad32a848e9170❙horizontal-video-shelf.view❙
04-04 20:13:07.295 28669 28669 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_shelf.eml|5eff32bb752d0020|CellType|horizontal_shelf_content.eml|b5b4b6f6ed66642b|ContainerType|ContainerType|CollectionType| BufferStrings: button.eml|fdca390897fbe814❙cell_video_attribute.eml|9e0c687c5bdc2f0❙Ne$H❙horizontal_shelf_content.shelf_header❙shelf_header.eml|ba6ad32a848e9170❙horizontal-video-shelf.view❙
04-04 20:13:07.297 28669 28669 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_shelf.eml|5eff32bb752d0020|CellType|horizontal_shelf_content.eml|b5b4b6f6ed66642b|ContainerType|ContainerType|shelf_header.eml|ba6ad32a848e9170|modern_type_shelf_header_content.eml|37506ae26b8b0bec|ContainerType| BufferStrings: horizontal_shelf_content.shelf_header❙1 songs❙sans-serif❙Music❙sans-serif❙eml.shelf_header❙

The same goes for Games as well.

04-04 20:23:27.036 28669 28669 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_shelf.eml|5eff32bb752d0020|CellType|horizontal_shelf_content.eml|b5b4b6f6ed66642b|ContainerType|ContainerType|CollectionType| BufferStrings: button.eml|fdca390897fbe814❙cell_video_attribute.eml|9e0c687c5bdc2f0❙Ne$H❙horizontal_shelf_content.shelf_header❙shelf_header.eml|ba6ad32a848e9170❙horizontal-video-shelf.view❙
04-04 20:23:27.037 28669 28669 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_shelf.eml|5eff32bb752d0020|CellType|horizontal_shelf_content.eml|b5b4b6f6ed66642b|ContainerType|ContainerType|shelf_header.eml|ba6ad32a848e9170|modern_type_shelf_header_content.eml|37506ae26b8b0bec|ContainerType| BufferStrings: horizontal_shelf_content.shelf_header❙Games❙sans-serif❙eml.shelf_header❙
04-04 20:23:27.038 28669 28669 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_shelf.eml|5eff32bb752d0020|CellType|horizontal_shelf_content.eml|b5b4b6f6ed66642b|ContainerType|ContainerType|shelf_header.eml|ba6ad32a848e9170|modern_type_shelf_header_content.eml|37506ae26b8b0bec|ContainerType|ContainerType| BufferStrings: horizontal_shelf_content.shelf_header❙Games❙sans-serif❙eml.shelf_header❙

[LisoUseInAIKyrios]

Video for reproduction: https://youtu.be/W8kI1na3S2M

The horizontal shelves could ignore if the player is currently open, as I don't think these shelves appear in the player suggestions.

Edit: Fixed with 3864f35