Window + Take goes on forever

[JeanMeche]

Bug Report

Current Behavior
The observable is never completed after the last take.

Reproduction

• REPL or Repo link:
  https://stackblitz.com/edit/rxjs-hzqcgq

const window = timer(0, 100)
  .pipe(
    windowTime(1000),
    take(3),
    flatMap( value => value.pipe(toArray()))
  )

Expected behavior
In the given example, I would expect to get a third array in my subscription. But I'm only getting 2. (take(n) gives n-1 results in the subscription)

Also would expect the observable to be completed.

Environment

• RxJS version: 6

[cartant]

This looks like a bug, to me. It looks like the last windowed observable doesn't complete for some reason - most likely related to the unsubscription effected by the take(3). It's not completing means that toArray doesn't complete/emit anything, etc.

FWIW, the map(win => win.pipe(take(2))), in this issue's snippet can be removed - it's not in the StackBlitz - the problem occurs without that line.

[martinsik]

Isn't this expected behavior? When windowTime unsubscribes it won't complete the last windowed observable.

[benlesh]

Hi @JeanMeche — thank you for taking the time to open this issue and for sharing your thoughtful feedback with the RxJS project. I’m sorry it took us so long to respond. Given how much time has passed and the lack of recent activity, I’m going to close this for now so the tracker reflects the work we’re likely to act on. If this is still relevant on a current RxJS release, please feel welcome to open a new issue with updated context and a reproduction. Thank you again for your contribution and patience.

— Ben