Skip to content

Do noop and identity really belong into the public exports of rxjs? #5407

Description

@felixfbecker

Bug Report

Current Behavior
This is a minor issue, but every time I type noop or identity in my projects I get a VS Code autocomplete suggestion to auto-import it from rxjs. This feels weird to me, because those functions don't really have anything to do with Observables. My natural place to import them from would be lodash, but instead rxjs is always suggested first. If anything you'd think a noop export from rxjs would be a "noop Observable", not a plain noop function.

This seems to have been very intentional though: 810c4d0

Expected behavior
These to just be internal functions (unless there's a good reason I am missing).

Environment

  • RxJS version: 6.5.5

Possible Solution
Not export in index.ts

Additional context/Screenshots

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions