Skip to content

fix: innerFrom throw ObservableTypeError when Observable Class is different (different version, duplicate code) - #6926

Closed
MeetzhDing wants to merge 2 commits into
ReactiveX:masterfrom
MeetzhDing:fix/innerFromError
Closed

fix: innerFrom throw ObservableTypeError when Observable Class is different (different version, duplicate code)#6926
MeetzhDing wants to merge 2 commits into
ReactiveX:masterfrom
MeetzhDing:fix/innerFromError

Conversation

@MeetzhDing

@MeetzhDing MeetzhDing commented Apr 2, 2022

Copy link
Copy Markdown

When using webpack or rollup, we may bundle different version rxjs into websites.

Function using innerFrom (eg. mergeMap, from) will throw InvalidObservableTypeError when input is not instanceOf current version Observable, and this problem is to hard to locate.

The util isObservable can solve this problem.

@benlesh

@MeetzhDing

Copy link
Copy Markdown
Author

@benlesh please have a look at this pr.

@tien

tien commented May 30, 2023

Copy link
Copy Markdown

Same issue is happening with bundler like Vite

@benlesh

benlesh commented Jul 22, 2026

Copy link
Copy Markdown
Member

Hi @MeetzhDing — thank you for the time, care, and thoughtfulness you put into this pull request. I’m sorry we weren’t able to respond in a reasonable timeframe. Since the codebase and surrounding context have moved on and this hasn’t seen recent activity, I’m going to close it for now. That’s a reflection of our delayed triage, not a lack of appreciation for your contribution. If the change is still relevant, please feel welcome to open a fresh pull request against the current codebase. Thank you again for contributing to RxJS and for your patience.

— Ben

@benlesh benlesh closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants