Skip to content

refactor: replace the array for emitted values by the other sources on withLatestFrom - #7020

Closed
Yozmo wants to merge 1 commit into
ReactiveX:masterfrom
Yozmo:refactor-withlastestfrom
Closed

refactor: replace the array for emitted values by the other sources on withLatestFrom#7020
Yozmo wants to merge 1 commit into
ReactiveX:masterfrom
Yozmo:refactor-withlastestfrom

Conversation

@Yozmo

@Yozmo Yozmo commented Jul 10, 2022

Copy link
Copy Markdown

Replacing the hasValue array used to find whether or not the other sources have emitted. Using remainingValues which it's initialized with inputs.length and a boolean flag hasFirstValue (to find out if the current inner observable has emitted or not its first value) can easily replace the array.

@Yozmo Yozmo changed the title refactor: replace the array for emitted values refactor: replace the array for emitted values of inputs on withLatestFrom Jul 10, 2022
@Yozmo Yozmo changed the title refactor: replace the array for emitted values of inputs on withLatestFrom refactor: replace the array for emitted values by the other inputs on withLatestFrom Jul 10, 2022
@Yozmo Yozmo changed the title refactor: replace the array for emitted values by the other inputs on withLatestFrom refactor: replace the array for emitted values by the other sources on withLatestFrom Jul 10, 2022
@benlesh

benlesh commented Jul 22, 2026

Copy link
Copy Markdown
Member

Hi @Yozmo — thank you for the time, care, and thoughtfulness you put into this pull request. I’m sorry we weren’t able to respond in a reasonable timeframe. Since the codebase and surrounding context have moved on and this hasn’t seen recent activity, I’m going to close it for now. That’s a reflection of our delayed triage, not a lack of appreciation for your contribution. If the change is still relevant, please feel welcome to open a fresh pull request against the current codebase. Thank you again for contributing to RxJS and for your patience.

— Ben

@benlesh benlesh closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants