chore: update docs app to Angular v15 - #7238
Conversation
| this.location.subscribe((state) => { | ||
| return this.urlSubject.next(state.url || ''); | ||
| }); |
There was a problem hiding this comment.
| this.location.subscribe((state) => { | |
| return this.urlSubject.next(state.url || ''); | |
| }); | |
| this.location.subscribe((state) => return this.urlSubject.next(state.url ?? '')); |
There was a problem hiding this comment.
@LcsGa Did you mean this?
| this.location.subscribe((state) => { | |
| return this.urlSubject.next(state.url || ''); | |
| }); | |
| this.location.subscribe((state) => this.urlSubject.next(state.url || '')); |
There was a problem hiding this comment.
Oh indeed! Forget to remove the return keyboard plus I would have used the nullish coalescing operator ?? instead of ||
| const value = params[key]; | ||
| return (value === undefined) ? acc : | ||
| acc += (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`; | ||
| return value === undefined ? acc : (acc += (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`); |
There was a problem hiding this comment.
| return value === undefined ? acc : (acc += (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`); | |
| return value === undefined ? acc : (acc + (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`); |
= is not needed since you already return the result which will be the new acc
There was a problem hiding this comment.
Which needs to become new acc, therefore it is needed 🙂
Anyways, I didn't change anything in this PR, a lot of fixes here are just Prettier uglifying things (I don't like Prettier), therefore, if it worked before, I wouldn't change it now.
|
Hi @jakovljevic-mladen — thank you for the time, care, and thoughtfulness you put into this pull request. I’m sorry we weren’t able to respond in a reasonable timeframe. Since the codebase and surrounding context have moved on and this hasn’t seen recent activity, I’m going to close it for now. That’s a reflection of our delayed triage, not a lack of appreciation for your contribution. If the change is still relevant, please feel welcome to open a fresh pull request against the current codebase. Thank you again for contributing to RxJS and for your patience. — Ben |
4 participants
Description:
Update docs app to Angular v15
Related issue (if exists):
None