Merge pull request #53 from RealOrangeOne/master

Add linter

Author: RealOrangeOne

.eslintrc

@@ -1,10 +1,33 @@
 {
   "extends": "airbnb",
-  plugins: [
+  "plugins": [
     "react",
     "react-native"
   ],
+  "env": {
+    "mocha": true
+  },
+  "parser": "babel-eslint",
   "rules": {
-    "comma-dangle": 0
+    "no-unused-vars": [2, {"vars": "all", "args": "none"}],
+    "comma-dangle": 0,
+    "func-names": 0,
+    "prefer-arrow-callback": 0,
+    "global-require": 0,
+    "react/prefer-es6-class": 0,
+    "no-underscore-dangle": 0,
+    "prefer-rest-params": 0,
+    "guard-for-in": 0,
+    "no-restricted-syntax": 0,
+    "prefer-template": 0,
+    "no-console": 0,
+    "max-len": [
+      2,
+      120,
+      2,
+      {
+        "ignoreComments": true
+      }
+    ]
   }
 }

CONTRIBUTING.md

@@ -12,5 +12,5 @@ The API should be as close to the API of `react-native` as possible. If there ar
 ## Incrementing the version number
 In simple: __Don't__. Leave that for us to manage when deploying!
 
-## Tests (Ignore for now!)
+## Tests
 When adding a new mock, make sure it's got some in-depth tests, and that the linter passes. PRs with failing tests or tests that arent in-depth enough won't be merged. This keeps the mock as stable as possible.

mock.js

@@ -1,7 +1,7 @@
-var ReactNativeMock = require('./build/react-native');
+const ReactNativeMock = require('./build/react-native');
 
 // the cache key that real react native would get
-var key = require.resolve('react-native');
+const key = require.resolve('react-native');
 
 // make sure the cache is filled with our lib
 require.cache[key] = {
@@ -10,4 +10,3 @@ require.cache[key] = {
   loaded: true,
   exports: ReactNativeMock,
 };
-

package.json

@@ -5,10 +5,11 @@
   "main": "build/react-native.js",
   "scripts": {
     "prepublish": "npm run build",
-    "test": "mocha --require babel-core/register test/**/*.js",
-    "test:watch": "npm run test -- --watch",
+    "test": "npm run lint && npm run mocha",
+    "mocha": "mocha --require babel-core/register test/**/*.js",
+    "mocha:watch": "npm run test -- --watch",
     "build": "babel src --out-dir build",
-    "lint": "eslint 'src/' 'test/'"
+    "lint": "eslint 'src/' 'test/' 'mock.js'"
   },
   "repository": {
     "type": "git",
@@ -30,6 +31,7 @@
     "babel": "=6.5.2",
     "babel-cli": "=6.9.0",
     "babel-core": "=6.9.0",
+    "babel-eslint": "=6.0.4",
     "babel-preset-airbnb": "=2.0.0",
     "babel-preset-react-native": "=1.8.0",
     "chai": "=3.5.0",

src/NativeModules/AppState.js

@@ -1,18 +1,18 @@
 import DeviceEventEmitter from '../plugins/DeviceEventEmitter';
 
-let app_state = 'active';
+let _appState = 'active';
 
 DeviceEventEmitter.on('appStateDidChange', data => {
-  app_state = data.app_state;
+  _appState = data._appState;
 });
 
 const AppState = {
   getCurrentAppState(callback, error) {
-    Promise.resolve({ app_state }).then(callback);
+    Promise.resolve({ _appState }).then(callback);
   },
 
   __setAppState(appState) {
-    DeviceEventEmitter.emit('appStateDidChange', { app_state: appState });
+    DeviceEventEmitter.emit('appStateDidChange', { _appState: appState });
   },
 };
 

src/NativeModules/DatePickerAndroid.js

@@ -1,7 +1,7 @@
 // TODO(lmr): figure out a good way to have separate responses like "dismissed" vs "set".
 const DatePickerAndroid = {
   open(options) {
-    return Promise.resolve().then({ action: "dismissedAction" });
+    return Promise.resolve().then({ action: 'dismissedAction' });
   },
 };
 

src/NativeModules/ImagePickerIOS.js

@@ -1,5 +1,5 @@
-let _canRecordVideos = true;
-let _canUseCamera = true;
+const _canRecordVideos = true;
+const _canUseCamera = true;
 
 const ImagePickerIOS = {
   canRecordVideos(callback) {

src/api/ActionSheetIOS.js

@@ -1,6 +1,5 @@
-
 import ActionSheetManager from '../NativeModules/ActionSheetManager';
-import invariant from'invariant';
+import invariant from 'invariant';
 import processColor from '../plugins/processColor';
 
 const ActionSheetIOS = {
@@ -14,7 +13,7 @@ const ActionSheetIOS = {
       'Must provide a valid callback'
     );
     ActionSheetManager.showActionSheetWithOptions(
-      {...options, tintColor: processColor(options.tintColor)},
+      { ...options, tintColor: processColor(options.tintColor) },
       callback
     );
   },
@@ -37,7 +36,7 @@ const ActionSheetIOS = {
       'Must provide a valid successCallback'
     );
     ActionSheetManager.showShareActionSheetWithOptions(
-      {...options, tintColor: processColor(options.tintColor)},
+      { ...options, tintColor: processColor(options.tintColor) },
       failureCallback,
       successCallback
     );

src/api/AlertIOS.js

@@ -36,9 +36,11 @@ class AlertIOS {
    */
   static alert(title, message, callbackOrButtons, type) {
     if (typeof type !== 'undefined') {
-      console.warn('AlertIOS.alert() with a 4th "type" parameter is deprecated and will be removed. Use AlertIOS.prompt() instead.');
-        this.prompt(title, message, callbackOrButtons, type);
-        return;
+      console.warn(
+        'AlertIOS.alert() with a 4th "type" parameter is deprecated and will be removed. Use AlertIOS.prompt() instead.'
+      );
+      this.prompt(title, message, callbackOrButtons, type);
+      return;
     }
     this.prompt(title, message, callbackOrButtons, 'default');
   }
@@ -85,32 +87,24 @@ class AlertIOS {
    */
   static prompt(title, message, callbackOrButtons, type, defaultValue) {
     if (typeof type === 'function') {
-      console.warn(
-        'You passed a callback function as the "type" argument to AlertIOS.prompt(). React Native is ' +
-        'assuming  you want to use the deprecated AlertIOS.prompt(title, defaultValue, buttons, callback) ' +
-        'signature. The current signature is AlertIOS.prompt(title, message, callbackOrButtons, type, defaultValue) ' +
-        'and the old syntax will be removed in a future version.');
-
-      var callback = type;
-      var defaultValue = message;
+      const callback = type;
       AlertManager.alertWithArgs({
         title: title || undefined,
         type: 'plain-text',
-        defaultValue,
+        message,
       }, (id, value) => {
         callback(value);
       });
       return;
     }
 
-    var callbacks = [];
-    var buttons = [];
-    var cancelButtonKey;
-    var destructiveButtonKey;
+    let callbacks = [];
+    const buttons = [];
+    let cancelButtonKey;
+    let destructiveButtonKey;
     if (typeof callbackOrButtons === 'function') {
       callbacks = [callbackOrButtons];
-    }
-    else if (callbackOrButtons instanceof Array) {
+    } else if (callbackOrButtons instanceof Array) {
       callbackOrButtons.forEach((btn, index) => {
         callbacks[index] = btn.onPress;
         if (btn.style === 'cancel') {
@@ -119,7 +113,7 @@ class AlertIOS {
           destructiveButtonKey = String(index);
         }
         if (btn.text || index < (callbackOrButtons || []).length - 1) {
-          var btnDef = {};
+          const btnDef = {};
           btnDef[index] = btn.text || '';
           buttons.push(btnDef);
         }
@@ -135,9 +129,12 @@ class AlertIOS {
         defaultValue,
         cancelButtonKey,
         destructiveButtonKey,
-      }, (id, value) => {
-        var cb = callbacks[id];
-        cb && cb(value);
+      },
+      (id, value) => {
+        const cb = callbacks[id];
+        if (cb) {
+          cb(value);
+        }
       }
     );
   }