Skip to content

Commit 918f89c

Browse files
committed
Updating templates with some place holders for links
Updating tests to reflect the change above
1 parent fd227fb commit 918f89c

4 files changed

Lines changed: 15 additions & 7 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
A scheduled export **[{data.context.job_name}]({environment.url}/api/exports/v1/exports/{data.context.export_id})** has completed.
1+
A scheduled export **[{data.context.job_name}]({environment.url()}/api/exports/v1/exports/{data.context.export_id})** has completed.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
A scheduled export ({data.context.job_name}) has failed.
1+
A scheduled export **[{data.context.job_name}]({environment.url()}/insights/jobs/{data.context.job_id})** has failed.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
A scheduled export ({data.context.job_name}) has failed and been automatically paused.
1+
A scheduled export **[{data.context.job_name}]({environment.url()}/insights/jobs/{data.context.job_id})** has failed and been automatically paused.

common-template/src/test/java/drawer/TestSchedulerTemplate.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import static helpers.SchedulerTestHelpers.createSchedulerExportCompleteAction;
1515
import static helpers.SchedulerTestHelpers.createSchedulerJobFailedAction;
1616
import static helpers.SchedulerTestHelpers.createSchedulerJobFailedPausedAction;
17-
import static org.junit.jupiter.api.Assertions.assertEquals;
1817
import static org.junit.jupiter.api.Assertions.assertTrue;
1918

2019
@QuarkusTest
@@ -27,21 +26,30 @@ class TestSchedulerTemplate {
2726
void testRenderedTemplateExportComplete() {
2827
Action action = createSchedulerExportCompleteAction();
2928
String result = renderTemplate(SCHEDULER_EXPORT_COMPLETE, action);
30-
assertEquals("A scheduled export (Test Export Job) has completed.", result);
29+
assertTrue(result.contains("A scheduled export"));
30+
assertTrue(result.contains("**[Test Export Job]"));
31+
assertTrue(result.contains("/api/exports/v1/exports/export-67890)**"));
32+
assertTrue(result.contains("has completed"));
3133
}
3234

3335
@Test
3436
void testRenderedTemplateJobFailed() {
3537
Action action = createSchedulerJobFailedAction();
3638
String result = renderTemplate(SCHEDULER_JOB_FAILED, action);
37-
assertEquals("A scheduled export (Test Failed Job) has failed.", result);
39+
assertTrue(result.contains("A scheduled export"));
40+
assertTrue(result.contains("**[Test Failed Job]"));
41+
assertTrue(result.contains("/insights/jobs/job-54321)**"));
42+
assertTrue(result.contains("has failed"));
3843
}
3944

4045
@Test
4146
void testRenderedTemplateJobFailedPaused() {
4247
Action action = createSchedulerJobFailedPausedAction();
4348
String result = renderTemplate(SCHEDULER_JOB_FAILED_PAUSED, action);
44-
assertTrue(result.contains("A scheduled export (Test Paused Job) has failed and been automatically paused"));
49+
assertTrue(result.contains("A scheduled export"));
50+
assertTrue(result.contains("**[Test Paused Job]"));
51+
assertTrue(result.contains("/insights/jobs/job-99999)**"));
52+
assertTrue(result.contains("has failed and been automatically paused"));
4553
}
4654

4755
String renderTemplate(final String eventType, final Action action) {

0 commit comments

Comments
 (0)