Skip to content

Commit b64a43b

Browse files
committed
Remove redundant appends to optimize performance
1 parent 3b0ad09 commit b64a43b

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

edge.go

+2-5
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,10 @@ func (e Edge) Encode() string {
9393
p = append(p, fmt.Sprintf("%s:%v", k, ToString(v)))
9494
}
9595

96-
s = append(s, "{")
97-
s = append(s, strings.Join(p, ","))
98-
s = append(s, "}")
96+
s = append(s, "{", strings.Join(p, ","), "}")
9997
}
10098

101-
s = append(s, "]->")
102-
s = append(s, "(", e.Destination.Alias, ")")
99+
s = append(s, "]->", "(", e.Destination.Alias, ")")
103100

104101
return strings.Join(s, "")
105102
}

node.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ func (n Node) Encode() string {
7474
p = append(p, fmt.Sprintf("%s:%v", k, ToString(v)))
7575
}
7676

77-
s = append(s, "{")
78-
s = append(s, strings.Join(p, ","))
79-
s = append(s, "}")
77+
s = append(s, "{", strings.Join(p, ","), "}")
8078
}
8179

8280
s = append(s, ")")

path.go

+9-10
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ func PathNew(nodes []interface{}, edges []interface{}) Path {
1919
for i := 0; i < len(edges); i++ {
2020
Edges[i] = edges[i].(*Edge)
2121
}
22-
23-
return Path{
24-
Edges : Edges,
25-
Nodes : Nodes,
22+
23+
return Path{
24+
Edges: Edges,
25+
Nodes: Nodes,
2626
}
2727
}
2828

@@ -38,7 +38,7 @@ func (p Path) GetNode(index int) *Node {
3838
return p.Nodes[index]
3939
}
4040

41-
func (p Path) GetEdge(index int) *Edge{
41+
func (p Path) GetEdge(index int) *Edge {
4242
return p.Edges[index]
4343
}
4444

@@ -63,16 +63,15 @@ func (p Path) String() string {
6363
edgeCount := p.EdgeCount()
6464
for i := 0; i < edgeCount; i++ {
6565
var node = p.GetNode(i)
66-
s = append(s, "(" , fmt.Sprintf("%v", node.ID) , ")")
66+
s = append(s, "(", fmt.Sprintf("%v", node.ID), ")")
6767
var edge = p.GetEdge(i)
6868
if node.ID == edge.srcNodeID {
69-
s = append(s, "-[" , fmt.Sprintf("%v", edge.ID) , "]->")
69+
s = append(s, "-[", fmt.Sprintf("%v", edge.ID), "]->")
7070
} else {
71-
s= append(s, "<-[" , fmt.Sprintf("%v", edge.ID) , "]-")
71+
s = append(s, "<-[", fmt.Sprintf("%v", edge.ID), "]-")
7272
}
7373
}
74-
s = append(s, "(" , fmt.Sprintf("%v", p.GetNode(edgeCount).ID) , ")")
75-
s = append(s, ">")
74+
s = append(s, "(", fmt.Sprintf("%v", p.GetNode(edgeCount).ID), ")", ">")
7675

7776
return strings.Join(s, "")
7877
}

0 commit comments

Comments
 (0)