Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change passcode length to 4 chars from 6 chars #15

Open
xuxey opened this issue Jul 9, 2023 · 3 comments
Open

Change passcode length to 4 chars from 6 chars #15

xuxey opened this issue Jul 9, 2023 · 3 comments

Comments

@xuxey
Copy link
Contributor

xuxey commented Jul 9, 2023

Changes may also be needed in rp2023
@AydanPirani
Copy link
Contributor

@xuxey are these not already implemented? looking at this...

https://github.com/ReflectionsProjections/rp-core/blame/f5120a1e7b421b4bca189ef6001e8de8ee2efec7/src/auth/auth.service.ts#L57-L59

@xuxey
Copy link
Contributor Author

xuxey commented Mar 5, 2024

@xuxey are these not already implemented? looking at this...

https://github.com/ReflectionsProjections/rp-core/blame/f5120a1e7b421b4bca189ef6001e8de8ee2efec7/src/auth/auth.service.ts#L57-L59

Correct, this is unimplemented

@xuxey
Copy link
Contributor Author

xuxey commented Mar 5, 2024

I think the title is worded a bit confusingly, we talked about reducing the number of chars from 6 to 4 to make logins more convenient (the security aspect from this was not a huge concern because of API ratelimiting) @AydanPirani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuxey @AydanPirani