Avoid recursively locking gpcm mutex

ppebb · ppebb · commit 550f70c9ed54 · 2025-04-12T19:29:31.000-05:00
diff --git a/gpcm/kick.go b/gpcm/kick.go
@@ -131,10 +131,15 @@ func KickPlayerCustomMessage(profileID uint32, reason string, message WWFCErrorM
 
 		for _, match := range findMatchingSessions(session) {
 			pids = append(pids, match.User.ProfileId)
+
+			mutex.Unlock()
 			match.replyError(gpError)
+			mutex.Lock()
 		}
 
+		mutex.Unlock()
 		session.replyError(gpError)
+		mutex.Lock()
 	}
 
 	// After 3 seconds, send kick order to all players

Original file line number	Diff line number	Diff line change
`@@ -131,10 +131,15 @@ func KickPlayerCustomMessage(profileID uint32, reason string, message WWFCErrorM`
`131`	`131`
`132`	`132`	`for _, match := range findMatchingSessions(session) {`
`133`	`133`	`pids = append(pids, match.User.ProfileId)`
	`134`	`+`
	`135`	`+ mutex.Unlock()`
`134`	`136`	`match.replyError(gpError)`
	`137`	`+ mutex.Lock()`
`135`	`138`	`}`
`136`	`139`
	`140`	`+ mutex.Unlock()`
`137`	`141`	`session.replyError(gpError)`
	`142`	`+ mutex.Lock()`
`138`	`143`	`}`
`139`	`144`
`140`	`145`	`// After 3 seconds, send kick order to all players`