-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will bs4Dash going to support bootstrap 5? #362
Comments
Thanks for your question! At the moment, here are my thoughts:
|
Thanks a lot @DivadNojnarg for your answer. I saw, and use, |
@agenius-mohammed-ali this, currently, is the best "getting started with |
Thanks @cpsievert so much for sharing the article. I am impressed with how far
|
I'm hoping we'll reach that point in the next 6-12 months, but also note that the Shiny team has a very high bar for calling something stable.
You could view it that way, but also keep in mind that bslib's only dependency is Bootstrap (i.e., no AdminLTE) which means it should be a lot more compatible with / portable to other Bootstrap-compatible projects, but you might find certain features a bit lacking at this point (if you think of critical things that are missing, please let us know!) |
Thanks a lot @cpsievert |
According to AdminLTEs GitHub Version 3.2.0 should support bootstrap 5. |
See above
|
So you're waiting for AdminLTE 4.0? |
@DivadNojnarg @AshesITR @cpsievert etc., the latest AdminLTE Beta Release: v4.0.0-beta1 supports bootstrap 5 just FYI. Seems like the release is pretty stable but there is still WIP mostly related to docs, examples, etc. The GitHub Project Board is here: https://github.com/orgs/ColorlibHQ/projects/1 |
The beta version does not seem super polished:
I can have a naive look within bs4Dash and see if there are other outstanding issues. Screen.Recording.2024-08-01.at.19.25.43.mov |
AdminLTE Beta 2 released: https://github.com/ColorlibHQ/AdminLTE/releases/tag/v4.0.0-beta2. The blinking seems to be fixed. |
@jimbrig I started to look at it closely: 94626c6. However, it's much worse than I thought. There are so many missing pieces: socialBox, userBox, boxProfile, ... are just gone. I have no control over if this will be re-included at a later point and when. My suggestion would be a bs5Dash. I see no viable alternative to this, as it would be extremely frustrating for users to migrate and have so many breaking changes. |
I agree with this all together and think that there are other benefits to this approach also. Always nice to start with a fresh package! If you guys do end up going this route I'd think of it as bslib's shinydashboard (akin to how shinydashboard implemented AdminLTE framework against shiny's original bootstrap 3). |
Hi,
Thank you for this great package. Only I wonder if there are plans to upgrade or create a version that supports bootstrap 5 and next versions of bootstraps?
Thank you
The text was updated successfully, but these errors were encountered: