Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade_dependency #3

Open
DivadNojnarg opened this issue Sep 4, 2020 · 5 comments
Open

upgrade_dependency #3

DivadNojnarg opened this issue Sep 4, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@DivadNojnarg
Copy link
Member

This function should look for the latest version on CDN and download file if the tag are differents. Moreover, it is better to keep a copy of old deps in a backup folder. Upgrading rarely works without issues ...

@DivadNojnarg DivadNojnarg added the enhancement New feature or request label Sep 4, 2020
@JohnCoene
Copy link
Member

Yes you're right, not an easy task though. Should the dependency back-up be kept outside the inst directory? This could quickly become heavy with files that are not used in the package and should not be installed/downloaded by users.

@DivadNojnarg
Copy link
Member Author

We could create a temp file and ask the user if if wants to save it: we can put a command in the console to copy and paste

@DivadNojnarg
Copy link
Member Author

DivadNojnarg commented Sep 4, 2020

Comparing version is going to be complex: packages follow different rules and we can't check all of them:

  • 3.0.0-rc.6 (admin-lte)
  • 1.0.0-alpha.7 (tabler)
  • 5.0.0-alpha1 (bootstrap)
  • 16.0.0-experimental-def3445 (react) (we very unlikely want react but we may imagine other doing like this)

Maybe we reject alpha/beta/rc versions. What do you think @JohnCoene?

Otherwise I suggest to overwrite everything instead of writing an exotic script and ask for confirmation like in devtools or usethis ...

@DivadNojnarg
Copy link
Member Author

upgrade rename to update to allow downgrade option (possible during development)

@JohnCoene
Copy link
Member

Argh. Hard to tell what's best here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants