txscript: return ErrCleanStack for witness cleanstack failures

Roasbeef · Roasbeef · commit 023589605313 · 2026-04-28T22:44:05.000-07:00
The refreshed Bitcoin Core script reference tests expect witness
clean-stack failures to report CLEANSTACK rather than a generic
EVAL_FALSE result.
diff --git a/txscript/engine.go b/txscript/engine.go
@@ -910,7 +910,7 @@ func (vm *Engine) CheckErrorCondition(finalScript bool) error {
 	// compatibility with BIP16.
 	if finalScript && vm.isWitnessVersionActive(BaseSegwitWitnessVersion) &&
 		vm.dstack.Depth() != 1 {
-		return scriptError(ErrEvalFalse, "witness program must "+
+		return scriptError(ErrCleanStack, "witness program must "+
 			"have clean stack")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -910,7 +910,7 @@ func (vm *Engine) CheckErrorCondition(finalScript bool) error {`
`910`	`910`	`// compatibility with BIP16.`
`911`	`911`	`if finalScript && vm.isWitnessVersionActive(BaseSegwitWitnessVersion) &&`
`912`	`912`	`vm.dstack.Depth() != 1 {`
`913`		`- return scriptError(ErrEvalFalse, "witness program must "+`
	`913`	`+ return scriptError(ErrCleanStack, "witness program must "+`
`914`	`914`	`"have clean stack")`
`915`	`915`	`}`
`916`	`916`