✅ Access-Control-Allow-Headers allow "*"

[HardCoreQual]

in experss-zod-api has
response.set("Access-Control-Allow-Headers", "content-type");
but here also can be send and authorization for example, I think better solution is to have possibility send all cors settings in Config

[RobinTail]

I presume you're talking about this line:

https://github.com/RobinTail/express-zod-api/blob/master/src/endpoint.ts#L138

I agree. There could be more headers.

to have possibility send all cors settings in Config

What could these CORS setting look like in your opinion?

Should they configure these headers:
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#the_http_response_headers
? Or should there be something more than that?

@HardCoreQual

P.S. Thank you for your finding

[RobinTail]

@HardCoreQual , please check out my PR #503 .
Would this be enough to fulfill your needs?

[HardCoreQual]

Yes, thanks, I temporary switch project from createServer to attachRouting, but after this update, I can revert it :)

Can be bug that
ExpressZodEndpoidFactory.addExpressMiddleware(cors()) don't work // createServer
and is necessary to use expressApp.use(cors()) // attachRouting
or it work like expected ?

[RobinTail]

Yes, thanks, I temporary switch project from createServer to attachRouting, but after this update, I can revert it :)

great, then I'll merge and release it soon.
Thank you.

Can be bug that
ExpressZodEndpoidFactory.addExpressMiddleware(cors()) don't work // createServer
and is necessary to use expressApp.use(cors()) // attachRouting
or it work like expected ?

the factory's method addExpressMiddleware() (and it's alias use()) add middleware to the endpoint.
Currently all these middlewares are executed before the endpoint's handler.
However, the OPTIONS request (which is the part of the CORS workflow) is not being handled by the endpoint's handler.
Its case is special in the current implementation and completely controlled by the cors option in the config.
So, yes, I think it's something that should be improved as well by running middlewares for the OPTIONS request.
But I need to figure out the best way to do it.
Thank you for reporting this. I'll make a separate issue out of it. @HardCoreQual

[RobinTail]

Fixed in 7.6.1 🚀 @HardCoreQual

[RobinTail]

The feature released in version 7.5.0 🚀