feat-193: fixed client_id empty logging

varunverlencar · varunverlencar · commit 9e8974da9d84 · 2026-02-19T10:42:22.000-05:00
diff --git a/src/web_video_server.cpp b/src/web_video_server.cpp
@@ -294,9 +294,10 @@ bool WebVideoServer::handle_shutdown(
   }
 
   if (verbose_) {
+    const std::string client_id_info = client_id.empty() ? "" : " (client_id='" + client_id + "')";
     RCLCPP_INFO(
-      get_logger(), "Shutdown request for topic '%s' (client_id='%s'): stopped %d stream(s)",
-      topic.c_str(), client_id.c_str(), stopped);
+      get_logger(), "Shutdown request for topic '%s'%s: stopped %d stream(s)",
+      topic.c_str(), client_id_info.c_str(), stopped);
   }
 
   async_web_server_cpp::HttpReply::builder(async_web_server_cpp::HttpReply::ok)

Original file line number	Diff line number	Diff line change
`@@ -294,9 +294,10 @@ bool WebVideoServer::handle_shutdown(`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`if (verbose_) {`
	`297`	`+ const std::string client_id_info = client_id.empty() ? "" : " (client_id='" + client_id + "')";`
`297`	`298`	`RCLCPP_INFO(`
`298`		`- get_logger(), "Shutdown request for topic '%s' (client_id='%s'): stopped %d stream(s)",`
`299`		`- topic.c_str(), client_id.c_str(), stopped);`
	`299`	`+ get_logger(), "Shutdown request for topic '%s'%s: stopped %d stream(s)",`
	`300`	`+ topic.c_str(), client_id_info.c_str(), stopped);`
`300`	`301`	`}`
`301`	`302`
`302`	`303`	`async_web_server_cpp::HttpReply::builder(async_web_server_cpp::HttpReply::ok)`