Skip to content

Add sign in modal and overlay to obscure content until Auth0 #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add sign in modal and overlay to obscure content until Auth0 #1433

wants to merge 7 commits into from

Conversation

@brothhammer
Copy link
Collaborator

@brothhammer brothhammer commented Oct 21, 2025 •
edited
Loading

Brief Description

Place the Storybook manager logout control in the left sidebar under the search.

JIRA Link

Related Issue

General Notes

  • Add manager-side code to render a logout control in the Storybook sidebar instead of the top toolbar.
  • Create a dedicated DOM container (#sb-manager-logout-container) and append the logout button (#sb-manager-logout-dom) there.
  • Use a MutationObserver and re-placement logic to keep the control correctly positioned across Storybook re-renders.
  • Add CSS to force block/full-width layout and spacing so the logout button doesn’t crowd the search input.

Motivation and Context

We want to get a better idea of who is accessing the Astro components.

Issues and Limitations

  • Placement relies on current Storybook DOM selectors. If Storybook changes these in future versions, updates will be needed.
  • implementation defends against re-renders via MutationObserver, aggressive re-parenting by any other scripts could cause issues.

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e73bfba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 21, 2025 •
edited
Loading

✅ Deploy Preview for astro-preview ready!

Name Link
🔨 Latest commit e73bfba
🔍 Latest deploy log https://app.netlify.com/projects/astro-preview/deploys/68f92f01e0485d0008117549
😎 Deploy Preview https://deploy-preview-1433--astro-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 21, 2025 •
edited
Loading

✅ Deploy Preview for astro-stencil ready!

Name Link
🔨 Latest commit e73bfba
🔍 Latest deploy log https://app.netlify.com/projects/astro-stencil/deploys/68f92f0108fc1c0008d0cb6e
😎 Deploy Preview https://deploy-preview-1433--astro-stencil.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nortonprojects
nortonprojects approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@nortonprojects nortonprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No show-stopping changes, it looks good other than a verbiage change

packages/web-components/.storybook/preview.js
const info = document.createElement('p')
info.className = 'sb-auth-overlay-info'
info.textContent =
'Sign in with Auth0 to unlock stories and protected content.'
Copy link
Collaborator

@nortonprojects nortonprojects Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End users don't need to know our tech stack - we can get rid of the with Auth0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nortonprojects nortonprojects nortonprojects approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brothhammer @nortonprojects