Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.3 broke linting #22

Open
GottemHams opened this issue Feb 3, 2025 · 5 comments
Open

v1.0.3 broke linting #22

GottemHams opened this issue Feb 3, 2025 · 5 comments

Comments

@GottemHams
Copy link

For some reason, after Sublime pulled in the latest update for this package, linting stopped working altogether. There's nothing in the console even with debug mode enabled, and it doesn't show any indication of trying to run this linter either. I checked out tag 1.0.2 and that does work, so then I checked out 1.0.3 one last time and again it breaks.

@pierresh
Copy link
Collaborator

pierresh commented Feb 3, 2025

Hello,

Yes, sorry, the click-on tab brought a new problem. I fixed it through a force push a few minutes after the related commit and push, but it seems it did not consider it after I created the release in Github.
I just published 1.0.4, please let me know if it works, thanks.

@GottemHams
Copy link
Author

Yeah I think tags are generally immutable, so would make sense that GitHub didn't recreate the release. :> Seems to work again, thanks.

@GottemHams
Copy link
Author

Little sidenote about automatically linting when a tab is activated: it conflicts a lot with SublimeLinter's own show_panel_on_save setting, as well as the built-in console thingy and even the find function. Every time focus shifts away from the actual editor and back, it starts linting again and if there are (still) issues, the errors panel pops up (dismissing any search bars), I try to dismiss it and go back to find, but it already started linting again and the error panel will show back up soon enough.

@pierresh
Copy link
Collaborator

pierresh commented Feb 4, 2025

I do not use show_panel_on_save but indeed when I activate it, I can reproduce your problem.

I made some tests helped by ChatGPT but so far I have not managed to distinguish events from clicks on tabs from other focus events, and to check if the find panel is already opened or not... This behavior had been already there before I added this new ability to lint when focusing the file (clicking on save would also close the Find function).

I am not sure how this should be handled, maybe rather at the Sublime Linter level rather than at the plugin level.

@GottemHams
Copy link
Author

In my own case, being able to disable linting when focusing is probably enough. I don't really need continuous scanning anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants