Formatter configuration?

[KonerDev]

I was looking into how formatters are currently integrated in the library and I’m wondering what the intended design here is.

1. Right now the formatter seems effectively tied to the language instance (Language.formatter / LspLanguage.setFormatter). When using language servers the normal language formatter gets overridden by the LSP connection logic (LspFormatter). This makes it difficult to reliably provide a custom formatter.

2. There also doesn’t seem to be a clear API for swapping formatters at runtime (no dedicated setter).

What was the original idea for how formatter selection and override should work here?

[KonerDev]

@Rosemoe
The code editor should have a way to specifiy a custom formatter (if the formatter service is not language specific, for instance when connecting Prettier):

private FormatterProvider formatterProvider;

Usage:

editor.setFormatterProvider { language ->
    if (languageId in supportedLanguages) {
        PrettierFormatter(languageId)
    } else {
        null
    }
}

Now the formatter precedence should be:

1. Editor-level formatter (if not null)
2. Language formatter fallback

If you have a better idea, feel free to tell me.

This formatter issue is generally similiar to the styles issue. There is also no way to modify them reliably (e.g. for line number markers) without modifying the languages... Styles that are not language specific (e.g. Git markers) can't be easily set.