Lint: Fix more RSpec cops (#768)

Author: sunny

.rubocop_todo.yml

@@ -6,12 +6,14 @@
   class Item < ActiveRecord::Base; end
 
   describe MoneyRails::ActiveRecord::MigrationExtensions::SchemaStatements do
+    # rubocop:disable RSpec/BeforeAfterAll
     before :all do
       @connection = ActiveRecord::Base.connection
       @connection.drop_table :items if @connection.table_exists? :items
       @connection.create_table :items
       @connection.send :extend, described_class
     end
+    # rubocop:enable RSpec/BeforeAfterAll
 
     describe "add_money" do
       before do

spec/active_record/migration_extensions/schema_statements_spec.rb

@@ -6,10 +6,12 @@
   class Item < ActiveRecord::Base; end
 
   describe MoneyRails::ActiveRecord::MigrationExtensions::SchemaStatements do
+    # rubocop:disable RSpec/BeforeAfterAll
     before :all do
       @connection = ActiveRecord::Base.connection
       @connection.send :extend, described_class
     end
+    # rubocop:enable RSpec/BeforeAfterAll
 
     describe "money" do
       before do

spec/active_record/migration_extensions/table_spec.rb

@@ -781,7 +781,7 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
         # TODO: these specs should mock locale_backend with expected values
         #       instead of manipulating it directly
         context "with an Italian locale" do
-          around(:each) do |example|
+          around do |example|
             I18n.with_locale(:it) do
               example.run
             end
@@ -810,7 +810,7 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
           end
 
           context "when using :currency locale backend" do
-            around(:each) do |example|
+            around do |example|
               Money.locale_backend = :currency
               example.run
             ensure
@@ -880,7 +880,7 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
       end
 
       context "with preserve_user_input set" do
-        around(:each) do |example|
+        around do |example|
           MoneyRails::Configuration.preserve_user_input = true
           example.run
           MoneyRails::Configuration.preserve_user_input = false
@@ -909,7 +909,7 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
 
         let(:read_monetized) { service.read_monetized(:discount, :discount_cents, options) }
 
-        around(:each) do |example|
+        around do |example|
           service # Instantiate instance which relies on Money.default_currency
           original_default_currency = Money.default_currency
           Money.default_currency = -> { default_currency_lambda.read_currency }
@@ -920,9 +920,14 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
         context "when allow_nil options is set" do
           let(:options) { { allow_nil: true } }
 
+          before do
+            allow(default_currency_lambda).to receive(:read_currency)
+          end
+
           it "does not attempt to read the fallback default currency" do
-            expect(default_currency_lambda).not_to receive(:read_currency)
             read_monetized
+
+            expect(default_currency_lambda).not_to have_received(:read_currency)
           end
         end
       end

spec/active_record/monetizable_spec.rb

@@ -32,7 +32,7 @@
     let(:money_object) { Money.new(12500) }
     let(:options) { {} }
 
-    subject { helper.humanized_money money_object, options }
+    subject(:humanized_money) { helper.humanized_money money_object, options }
 
     it { is_expected.to be_a String }
     it { is_expected.not_to include Money.default_currency.symbol }
@@ -47,11 +47,14 @@
     context "with deprecated symbol" do
       let(:options) { true }
 
-      before(:each) do
-        expect(helper).to receive(:warn)
+      before do
+        allow(helper).to receive(:warn)
       end
 
-      it { is_expected.to include Money.default_currency.symbol }
+      it do
+        expect(humanized_money).to include Money.default_currency.symbol
+        expect(helper).to have_received(:warn)
+      end
     end
 
     context "with a currency with an alternate symbol" do
@@ -82,7 +85,9 @@
   describe "#money_without_cents" do
     let(:options) { {} }
 
-    subject { helper.money_without_cents Money.new(12500), options }
+    subject(:money_without_cents) do
+      helper.money_without_cents Money.new(12500), options
+    end
 
     it { is_expected.to be_a String }
     it { is_expected.not_to include Money.default_currency.symbol }
@@ -91,11 +96,14 @@
     context "with deprecated symbol" do
       let(:options) { true }
 
-      before(:each) do
-        expect(helper).to receive(:warn)
+      before do
+        allow(helper).to receive(:warn)
       end
 
-      it { is_expected.to include Money.default_currency.symbol }
+      it do
+        expect(money_without_cents).to include Money.default_currency.symbol
+        expect(helper).to have_received(:warn)
+      end
     end
   end
 

spec/helpers/action_view_extension_spec.rb

@@ -11,11 +11,11 @@
     end
   end
 
-  config.before :each do
+  config.before do
     DatabaseCleaner.start
   end
 
-  config.after :each do
+  config.after do
     DatabaseCleaner.clean
   end
 end