Skip to content

Group::try_from_rng() is not supposed to allow identity points #1346

@daxpedda

Description

@daxpedda

The documentation of Group::try_from_rng() reads as following:

Returns an element chosen uniformly at random from the non-identity elements of this group.

However, we currently, quite intentionally, do allow identity elements here. For non-identity elements we have NonIdentity::random().

I'm not sure how we should address this, but at a minimum I think we should add some explicit documentation to these trait implementations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions