Skip to content

Commit 77af7f7

Browse files
committed
Remove deprecated crypto_common re-exports
It was re-exported as `common` from `aead`, `cipher`, and `universal-hash` in #2237, with the old name re-exported and "deprecated". Unfortuntaely, those deprecations don't work as expected, e.g. #![allow(unused_imports)] use digest::core_api::EagerHash; use digest::crypto_common::OutputSizeUser; This compiles without warnings: Compiling crypto-common v0.2.0-rc.15 Compiling digest v0.11.0-rc.10 Compiling foobar v0.1.0 (/private/tmp/foobar) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.05s Even if we change the re-export to use a deprecated module, ala: #[deprecated(...) pub mod crypto_common { pub use ::common::*; } ...that still doesn't work. Unfortunately deprecations only seem to apply to the individual items, and not their imports or the modules they're imported through.
1 parent ecc4e07 commit 77af7f7

4 files changed

Lines changed: 1 addition & 17 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cipher/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,3 @@ pub use common::{
5050
typenum::{self, consts},
5151
};
5252
pub use inout::{InOut, InOutBuf};
53-
54-
#[deprecated(since = "0.5.0", note = "use `cipher::common` instead")]
55-
pub use common as crypto_common;

digest/src/lib.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,6 @@ pub use common::{Output, OutputSizeUser, Reset, array, typenum, typenum::consts}
7373
pub use mac::{CtOutput, Mac, MacError, MacMarker};
7474
pub use xof_fixed::XofFixedWrapper;
7575

76-
#[cfg(feature = "block-api")]
77-
#[deprecated(
78-
since = "0.11.0",
79-
note = "`digest::core_api` has been replaced by `digest::block_api`"
80-
)]
81-
pub use block_api as core_api;
82-
83-
#[deprecated(since = "0.11.0", note = "use `digest::common` instead")]
84-
pub use common as crypto_common;
85-
8676
use common::typenum::Unsigned;
8777
use core::fmt;
8878

universal-hash/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ pub use common::{
1313
typenum::{self, consts},
1414
};
1515

16-
#[deprecated(since = "0.6.0", note = "use `universal_hash::common` instead")]
17-
pub use common as crypto_common;
18-
1916
use common::{BlockSizeUser, BlockSizes, ParBlocksSizeUser, array::Array};
2017
use core::slice;
2118
use subtle::ConstantTimeEq;

0 commit comments

Comments
 (0)