Conflict with ATC-Pretty Printer

[spvsgit]

We have ATC configured and enabled Pretty Printer checks. When using ABAP Cleaner, there is always ATC findings on Pretty Printer. We have to again explicitly open the custom code and adjust pretty printer.

We have ATC integrated into TR release framework. I doesnot allow us to move forward until we run Pretty Printer again.

[jmgrassau]

Hi spvsgit,

yes, ABAP cleaner indeed does not guarantee for all settings (even default settings) to be aligned with what Pretty Printer does. However, it should be possible to configure ABAP cleaner in a way that does not conflict with Pretty Printer. Could you maybe give some examples of where that is not possible?

Kind regards,
Jörg-Michael

[spvsgit]

Upper Case for keywords in Pretty Printer and Camel Case for CDS Fields in ABAP Cleaner. This could be usage of CDS views in ABAP programs, classes, etc.,

May be if SAP can update PrettyPrinter to use Camel Case in CDS Fields, it will be great.

[jmgrassau]

Hi spvsgit,

well, for such cases you should align your ABAP cleaner configuration with your Pretty Printer / ABAP Formatter configuration.

ABAP Formatter in ADT: Project -> Properties -> ABAP Development -> Editors -> Source Code Editors -> ABAP Formatter (project-specific):

Esp. "Keep Camel Case Identifiers" could be useful to keep the CDS view and field names in the Camel Case produced by ABAP cleaner.

ABAP cleaner: Configure … -> Rules in Current Profile -> section ---- PRETTY PRINTER ---- -> Convert upper and lower case

This allows even more fine-tuning than Pretty Printer, so it should be possible to align your settings. If there are still conflicts between ABAP cleaner and Pretty Printer that cannot be resolved by aligning configuration, please let me know.

Kind regards,
Jörg-Michael

P.S.: In the cleanup rule "Indent lines", you will have to select "never" for all "Align with following …" options, otherwise, you might get conflicts with indentation in Pretty Printer.

[spvsgit]

Will try these setting and share feedback

[spvsgit]

Submitted a Case to SAP. I see "Camel Case formatting" is not implemented in ATC Class. Hope SAP addresses this through below case.

ATC-Pretty Printer-Camel Case - CL_CI_TEST_PRETTY_PRINT - Issue (BC-ABA-LA)