Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister HealthCheckVerticles from shared map #176

Open
1 task done
s4heid opened this issue Aug 31, 2022 · 0 comments
Open
1 task done

Unregister HealthCheckVerticles from shared map #176

s4heid opened this issue Aug 31, 2022 · 0 comments
Labels
bug Something isn't working needs triage This issue needs to be investigated and confirmed as a valid

Comments

@s4heid
Copy link
Contributor

s4heid commented Aug 31, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

HealthCheckVerticles use a similar mechanism like EntityVerticles for data exchange. They register in NeonBee's shared map by their (unique) eventbus address, but never unregister. If a node dies, the entry remains in the shared map and will be tried to be contacted if data is requested. This means that the shared map fills up after some time with verticle addresses which are no longer reachable.

Expected Behavior

#159 addresses this issue for entity verticles. Once this issue is resolved, the unregistering mechanism should be reused for HealthCheckVerticles.

Steps To Reproduce

No response

Environment

all environments

Relevant log output

No response

Anything else?

No response

@s4heid s4heid added bug Something isn't working needs triage This issue needs to be investigated and confirmed as a valid labels Aug 31, 2022
@s4heid s4heid changed the title [Bug]: Unregister HealthCheckVerticles from shared map Unregister HealthCheckVerticles from shared map Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage This issue needs to be investigated and confirmed as a valid
Projects
None yet
Development

No branches or pull requests

1 participant