Skip to content

Commit f497cc7

Browse files
authoredApr 2, 2025··
refactor(ui5-side-navigation): add box-shadow by default (#11244)
1 parent e420b12 commit f497cc7

File tree

16 files changed

+8
-29
lines changed

16 files changed

+8
-29
lines changed
 

‎packages/fiori/src/themes/NavigationLayout.css

-4
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
width: 100%;
4141
}
4242

43-
:host(:not([is-phone])) ::slotted([ui5-side-navigation][slot="sideContent"]) {
44-
box-shadow: var(--_ui5_nl_side_navigation_box_shadow);
45-
}
46-
4743
:host([is-phone]) ::slotted([ui5-side-navigation][slot="sideContent"]) {
4844
width: 100%;
4945
box-shadow: none;

‎packages/fiori/src/themes/SideNavigation.css

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
font-family: "72override", var(--sapFontFamily);
1111
font-size: var(--sapFontSize);
1212
background: var(--sapList_Background);
13+
box-shadow: var(--_ui5_side_navigation_box_shadow);
14+
border-inline-end: var(--_ui5_side_navigation_border_right);
15+
box-sizing: border-box;
1316
}
1417

1518
:host([collapsed]) {
@@ -25,9 +28,8 @@
2528
height: 100%;
2629
display: flex;
2730
flex-direction: column;
28-
box-sizing: border-box;
31+
box-sizing: inherit;
2932
border-radius: inherit;
30-
border-inline-end: var(--_ui5_side_navigation_border_right);
3133
}
3234

3335
.ui5-sn-flexible {

‎packages/fiori/src/themes/base/NavigationLayout-parameters.css

-3
This file was deleted.

‎packages/fiori/src/themes/sap_fiori_3/parameters-bundle.css

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
@import "../base/ProductSwitchItem-parameters.css";
88
@import "./ShellBar-parameters.css";
99
@import "../base/SideNavigation-parameters.css";
10-
@import "../base/NavigationLayout-parameters.css";
1110
@import "../base/TimelineItem-parameters.css";
1211
@import "../base/UploadCollection-parameters.css";
1312
@import "../base/ViewSettingsDialog-parameters.css";

‎packages/fiori/src/themes/sap_fiori_3_dark/parameters-bundle.css

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
@import "../base/ProductSwitchItem-parameters.css";
88
@import "./ShellBar-parameters.css";
99
@import "../base/SideNavigation-parameters.css";
10-
@import "../base/NavigationLayout-parameters.css";
1110
@import "../base/TimelineItem-parameters.css";
1211
@import "../base/UploadCollection-parameters.css";
1312
@import "../base/ViewSettingsDialog-parameters.css";

‎packages/fiori/src/themes/sap_fiori_3_hcb/parameters-bundle.css

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
@import "./ProductSwitchItem-parameters.css";
88
@import "../base/ShellBar-parameters.css";
99
@import "../base/SideNavigation-parameters.css";
10-
@import "../base/NavigationLayout-parameters.css";
1110
@import "./TimelineItem-parameters.css";
1211
@import "./UploadCollection-parameters.css";
1312
@import "../base/ViewSettingsDialog-parameters.css";

‎packages/fiori/src/themes/sap_fiori_3_hcw/parameters-bundle.css

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
@import "./ProductSwitchItem-parameters.css";
88
@import "../base/ShellBar-parameters.css";
99
@import "../base/SideNavigation-parameters.css";
10-
@import "../base/NavigationLayout-parameters.css";
1110
@import "./TimelineItem-parameters.css";
1211
@import "./UploadCollection-parameters.css";
1312
@import "../base/ViewSettingsDialog-parameters.css";

‎packages/fiori/src/themes/sap_horizon/NavigationLayout-parameters.css

-3
This file was deleted.

‎packages/fiori/src/themes/sap_horizon/parameters-bundle.css

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
@import "./ShellBar-parameters.css";
1111
@import "./TimelineItem-parameters.css";
1212
@import "./SideNavigation-parameters.css";
13-
@import "./NavigationLayout-parameters.css";
1413
@import "./UploadCollection-parameters.css";
1514
@import "./Wizard-parameters.css";
1615
@import "./WizardTab-parameters.css";

‎packages/fiori/src/themes/sap_horizon_dark/NavigationLayout-parameters.css

-3
This file was deleted.

‎packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
@import "../base/SearchField-parameters.css";
1212
@import "./TimelineItem-parameters.css";
1313
@import "./SideNavigation-parameters.css";
14-
@import "./NavigationLayout-parameters.css";
14+
1515
@import "./UploadCollection-parameters.css";
1616
@import "./Wizard-parameters.css";
1717
@import "./WizardTab-parameters.css";

‎packages/fiori/src/themes/sap_horizon_hcb/NavigationLayout-parameters.css

-3
This file was deleted.

‎packages/fiori/src/themes/sap_horizon_hcb/parameters-bundle.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
@import "../base/ShellBar-parameters.css";
99
@import "./ShellBar-parameters.css";
1010
@import "./SideNavigation-parameters.css";
11-
@import "./NavigationLayout-parameters.css";
11+
1212
@import "./TimelineItem-parameters.css";
1313
@import "./UploadCollection-parameters.css";
1414
@import "../base/ViewSettingsDialog-parameters.css";

‎packages/fiori/src/themes/sap_horizon_hcw/NavigationLayout-parameters.css

-3
This file was deleted.

‎packages/fiori/src/themes/sap_horizon_hcw/parameters-bundle.css

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
@import "./ProductSwitchItem-parameters.css";
88
@import "../sap_horizon_hcb/ShellBar-parameters.css";
99
@import "./SideNavigation-parameters.css";
10-
@import "./NavigationLayout-parameters.css";
1110
@import "./TimelineItem-parameters.css";
1211
@import "./UploadCollection-parameters.css";
1312
@import "../base/ViewSettingsDialog-parameters.css";

‎packages/website/docs/_samples/fiori/SideNavigation/OverlayMode/main.css

+2
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,6 @@
1818

1919
#sideNavigation {
2020
width: 18rem;
21+
box-shadow: none;
22+
border-inline-end: none;
2123
}

0 commit comments

Comments
 (0)
Please sign in to comment.