Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-popover, ui5-dialog): fix finding keyboard focusable scroll containers #10891

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(ui5-popover, ui5-dialog): fix finding keyboard focusable scroll containers #10891

wants to merge 6 commits into from
+149 −0

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Feb 18, 2025 •
edited
Loading

  • change FocusableElements util to detect keyboard focusable scroll containers
  • correct focus outline style set for popup content

fixes #10806

@TeodorTaushanov TeodorTaushanov requested a review from a team February 19, 2025 11:40
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-popover, ui5-dialog): fix focusing keyboard focusable scrollers fix(ui5-popover, ui5-dialog): fix finding keyboard focusable scrollers Feb 19, 2025
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-popover, ui5-dialog): fix finding keyboard focusable scrollers fix(ui5-popover, ui5-dialog): fix finding keyboard focusable scroll containers Feb 19, 2025
Stoev
Stoev reviewed Feb 20, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider:

  • change FocusableElements util to detect keyboard focusable scroll containers
  • correct focus outline style set for popup content

@TeodorTaushanov
Copy link
Member Author

Please consider:

  • change FocusableElements util to detect keyboard focusable scroll containers
  • correct focus outline style set for popup content

Done.

Stoev
Stoev reviewed Feb 20, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TeodorTaushanov @Stoev