Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y |SideNavigation | ui5 | 2.8.0 | icons | svg ]: false positive on side nav icon #11204

Closed
1 task done
nopearson opened this issue Mar 27, 2025 · 2 comments
Closed
1 task done
Labels
ACC bug This issue is a bug in the code Low Prio TOPIC RD

Comments

@nopearson
Copy link

Bug Description

the icons in sidenav have role presentation in the group not the svg so it is giving a false positive on accessibility tools.

Affected Component

sidenav

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

2.8.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nopearson nopearson added the bug This issue is a bug in the code label Mar 27, 2025
@s-todorova s-todorova self-assigned this Mar 28, 2025
@s-todorova
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd,

Could you please take a look at this? Access Assistant reports a "Provide alternative text for images" issue for SideNavigation with icons. We should set the Icon mode to Decorative in the renderer of SideNavigationItems.

Best,
Siyana

@s-todorova
Copy link
Contributor

Hi @nopearson,

This issue was caused by an unintentional change of the default value of the Icon component's mode property, which we use inside the SideNavigationItems. It has been fixed with #10969.

Tested with AccessAssistant and on our side, there are no such problems reported for SideNavigation anymore, so I am closing this.

Best,
Siyana

@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RD Mar 31, 2025
@s-todorova s-todorova removed their assignment Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Status: Completed
Development

No branches or pull requests

2 participants