Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UploadCollection]: [Uploadcollection has missing items after update - in fact items with height 0] #11210

Open
1 task done
martin-ada-adam opened this issue Mar 28, 2025 · 2 comments
Labels
bug This issue is a bug in the code TOPIC RD

Comments

@martin-ada-adam
Copy link

Describe the bug

We are using UploadCollection and UploadCollectionItem do display uploaded document and processing state that is updated.
First render is always ok but after few updates some items can be missing at top of list - UploadCollectionItem is there but with height 0.

Isolated Example

https://stackblitz.com/edit/github-ruuxpbux?file=src%2FApp.tsx

Reproduction steps

Run example in stackblitz.com and wait for some updates (every 5s)

Expected Behaviour

All items should be always in list

Screenshots or Videos

Image
Image

UI5 Web Components for React Version

2.8.1

UI5 Web Components Version

2.8.0

Browser

Chrome

Operating System

Win11

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Hi @martin-ada-adam

In your example a React state was mutated which is not supported, but even with a fix the issue is still occuring. I've noticed that when updating all items every time the component rerenders, the issue is fixed, but since React keys should be stable, this is an anti-pattern and should probably only treated as workaround until a fix is available.

You can find the updated example here: https://stackblitz.com/edit/github-ruuxpbux-izrswvtr?file=src%2FApp.tsx

Since the affected components are developed in the ui5-webcomponents repo, I'm forwarding this issue there.


Hi Colleagues,
could you please take over?

Here you can find the provided example including the fix, but without our wrapper: https://stackblitz.com/edit/github-ruuxpbux-uqu36fwa?file=src%2FApp.tsx

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Mar 28, 2025
@hinzzx hinzzx self-assigned this Mar 31, 2025
@hinzzx hinzzx added bug This issue is a bug in the code TOPIC RD labels Mar 31, 2025
@hinzzx
Copy link
Contributor

hinzzx commented Mar 31, 2025

Hi colleagues @SAP/ui5-webcomponents-topic-rd ,

The issue is easily visible in the provided sample.
After few re-arrangements of the UploadCollection, an item is being 'hidden' visually (height is being 1px due to height: auto);

Image

Best Regards,
Stoyan

@hinzzx hinzzx removed their assignment Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC RD
Projects
Status: New Issues
Development

No branches or pull requests

3 participants