Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce vaadin-style side menu and legacy links to the angular app [~8-13] #11665

Open
8 tasks
Tracked by #11666
MartinWahnschaffe opened this issue Mar 16, 2023 · 1 comment
Open
8 tasks
Tracked by #11666
Labels
change A change of an existing feature (ticket type) ready Issue fulfills the definition of ready and can be implemented

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Mar 16, 2023

Problem Description

The angular app currently comes with a top menu, while the Vaadin "legacy" app uses a side menu.
To allow for a seamless switch between both apps, the angular app should come with a side menu that looks the same as the menu of the Vaadin app.

Proposed Change

  • Replace the top menu with a side menu that looks like the vaadin app's menu
  • Should be easy to adjust in code wheter a menu entry links to the angular app or the vaadin legacy app

Added Value/Benefit

See #11666

Acceptance Criteria

  • The menu looks like the vaadin app's menu
  • When connected to a legacy app, all menu entries that are not angular exclusive, link to the legacy app
  • It's still possible to "manually" open any angular app view, using the URL

Implementation Details

  • Add a new side menu component that is used by default. The old menu should stay available in the code, but not be used for now.
  • Style the menu to look like the Vaadin menu, including the SORMAS logo
  • Add all menu entries in the same order as in the Vaadin app
  • Define vaadin UI "legacy" paths for all menu entries
  • Add an environment config that defines the host address of the vaadin app. If defined, all menu entries that have a legacy path should link to the legacy app instead of the angular app

Mockups

No response

Additional Information

Out of scope

  • Considering active feature types and user rights to decide which menu entries should be visible will be done in a separate issue.
@MartinWahnschaffe
Copy link
Contributor Author

I have created a draft here: SORMAS-Foundation/SORMAS-Angular#511

  • Comes with basic side-menu that is not styled yet
  • Logic for legacy url is working
  • Feature configuration is not considered yet

@MartinWahnschaffe MartinWahnschaffe added the ready Issue fulfills the definition of ready and can be implemented label Apr 4, 2023
@MartinWahnschaffe MartinWahnschaffe removed their assignment Apr 4, 2023
@markusmann-vg markusmann-vg changed the title Introduce vaadin-style side menu and legacy links to the angular app Introduce vaadin-style side menu and legacy links to the angular app [~8-13] Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change A change of an existing feature (ticket type) ready Issue fulfills the definition of ready and can be implemented
Projects
None yet
Development

No branches or pull requests

3 participants