Cleanup CMake find modules

Author: Pansysk75

cmake/FindAmplifier.cmake

@@ -6,44 +6,25 @@
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
 if(NOT TARGET Amplifier::amplifier)
-  # compatibility with older CMake versions
-  if(AMPLIFIER_ROOT AND NOT Amplifier_ROOT)
-    set(Amplifier_ROOT
-        ${AMPLIFIER_ROOT}
-        CACHE PATH "Amplifier base directory"
-    )
-    unset(AMPLIFIER_ROOT CACHE)
-  endif()
 
   find_package(PkgConfig QUIET)
   pkg_check_modules(PC_AMPLIFIER QUIET amplifier)
 
   find_path(
     Amplifier_INCLUDE_DIR ittnotify.h
-    HINTS ${Amplifier_ROOT} ENV AMPLIFIER_ROOT ${PC_Amplifier_INCLUDEDIR}
+    HINTS ${AMPLIFIER_ROOT} ENV AMPLIFIER_ROOT ${PC_Amplifier_INCLUDEDIR}
           ${PC_Amplifier_INCLUDE_DIRS}
     PATH_SUFFIXES include
   )
 
   find_library(
     Amplifier_LIBRARY
     NAMES ittnotify libittnotify
-    HINTS ${Amplifier_ROOT} ENV AMPLIFIER_ROOT ${PC_Amplifier_LIBDIR}
+    HINTS ${AMPLIFIER_ROOT} ENV AMPLIFIER_ROOT ${PC_Amplifier_LIBDIR}
           ${PC_Amplifier_LIBRARY_DIRS}
     PATH_SUFFIXES lib lib64
   )
 
-  # Set Amplifier_ROOT in case the other hints are used
-  if(Amplifier_ROOT)
-    # The call to file is for compatibility for windows paths
-    file(TO_CMAKE_PATH ${Amplifier_ROOT} Amplifier_ROOT)
-  elseif(DEFINED ENV{AMPLIFIER_ROOT})
-    file(TO_CMAKE_PATH $ENV{AMPLIFIER_ROOT} Amplifier_ROOT)
-  else()
-    file(TO_CMAKE_PATH "${Amplifier_INCLUDE_DIR}" Amplifier_INCLUDE_DIR)
-    string(REPLACE "/include" "" Amplifier_ROOT "${Amplifier_INCLUDE_DIR}")
-  endif()
-
   set(Amplifier_LIBRARIES ${Amplifier_LIBRARY})
   set(Amplifier_INCLUDE_DIRS ${Amplifier_INCLUDE_DIR})
 
@@ -70,4 +51,8 @@ if(NOT TARGET Amplifier::amplifier)
     Amplifier::amplifier SYSTEM INTERFACE ${Amplifier_INCLUDE_DIR}
   )
   target_link_libraries(Amplifier::amplifier INTERFACE ${Amplifier_LIBRARIES})
+  mark_as_advanced(Amplifier_LIBRARIES, Amplifier_INCLUDE_DIRS)
+
+  # Set Amplifier_ROOT
+  get_filename_component(Amplifier_ROOT ${Amplifier_INCLUDE_DIR} DIRECTORY)
 endif()

cmake/FindAsio.cmake

@@ -8,38 +8,13 @@
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
 if(NOT TARGET Asio::asio)
-  # compatibility with older CMake versions
-  if(ASIO_ROOT AND NOT Asio_ROOT)
-    set(Asio_ROOT
-        ${ASIO_ROOT}
-        CACHE PATH "Asio base directory"
-    )
-    unset(ASIO_ROOT CACHE)
-  endif()
 
   find_path(
     Asio_INCLUDE_DIR asio.hpp
-    HINTS "${Asio_ROOT}" ENV ASIO_ROOT "${HPX_ASIO_ROOT}"
+    HINTS "${ASIO_ROOT}" ENV ASIO_ROOT "${HPX_ASIO_ROOT}"
     PATH_SUFFIXES include
   )
 
-  if(NOT Asio_INCLUDE_DIR)
-    hpx_error(
-      "Could not find Asio. Set Asio_ROOT as a CMake or environment variable to point to the Asio root install directory. Alternatively, set HPX_WITH_FETCH_ASIO=ON to fetch Asio using CMake's FetchContent (when using this option Asio will be installed together with HPX, be careful about conflicts with separately installed versions of Asio)."
-    )
-  endif()
-
-  # Set Asio_ROOT in case the other hints are used
-  if(Asio_ROOT)
-    # The call to file is for compatibility with windows paths
-    file(TO_CMAKE_PATH ${Asio_ROOT} Asio_ROOT)
-  elseif(DEFINED ENV{ASIO_ROOT})
-    file(TO_CMAKE_PATH $ENV{ASIO_ROOT} Asio_ROOT)
-  else()
-    file(TO_CMAKE_PATH "${Asio_INCLUDE_DIR}" Asio_INCLUDE_DIR)
-    string(REPLACE "/include" "" Asio_ROOT "${Asio_INCLUDE_DIR}")
-  endif()
-
   if(Asio_INCLUDE_DIR AND EXISTS "${Asio_INCLUDE_DIR}/asio/version.hpp")
     # Matches a line of the form:
     #
@@ -64,11 +39,13 @@ if(NOT TARGET Asio::asio)
     Asio
     REQUIRED_VARS Asio_INCLUDE_DIR
     VERSION_VAR Asio_VERSION_STRING
-    FOUND_VAR Asio_FOUND
   )
 
   add_library(Asio::asio INTERFACE IMPORTED)
   target_include_directories(Asio::asio SYSTEM INTERFACE ${Asio_INCLUDE_DIR})
 
-  mark_as_advanced(Asio_ROOT Asio_INCLUDE_DIR Asio_VERSION_STRING)
+  mark_as_advanced(Asio_INCLUDE_DIR Asio_VERSION_STRING)
+
+  # Set Asio_ROOT
+  get_filename_component(Asio_ROOT ${Asio_INCLUDE_DIR} DIRECTORY)
 endif()

cmake/FindBreathe.cmake

@@ -4,29 +4,16 @@
 # Distributed under the Boost Software License, Version 1.0. (See accompanying
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
-# compatibility with older CMake versions
-if(BREATHE_APIDOC_ROOT AND NOT Breathe_APIDOC_ROOT)
-  set(Breathe_APIDOC_ROOT
-      ${BREATHE_APIDOC_ROOT}
-      CACHE PATH "Breathe base directory"
-  )
-  unset(BREATHE_ROOT CACHE)
-endif()
-
 find_program(
   Breathe_APIDOC_EXECUTABLE
   NAMES breathe-apidoc
-  PATHS ${Breathe_APIDOC_ROOT} ENV Breathe_APIDOC_ROOT
+  PATHS ${BREATHE_APIDOC_ROOT} ENV BREATHE_APIDOC_ROOT
   DOC "Path to breathe-apidoc executable"
 )
 
-if(Breathe_APIDOC_ROOT)
-  file(TO_CMAKE_PATH ${Breathe_APIDOC_ROOT} Breathe_APIDOC_ROOT)
-endif()
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(
+  Breathe DEFAULT_MESSAGE Breathe_APIDOC_EXECUTABLE
+)
 
-if(Breathe_APIDOC_EXECUTABLE)
-  include(FindPackageHandleStandardArgs)
-  find_package_handle_standard_args(
-    Breathe DEFAULT_MESSAGE Breathe_APIDOC_EXECUTABLE
-  )
-endif()
+mark_as_advanced(Breathe_APIDOC_EXECUTABLE)

cmake/FindHwloc.cmake

@@ -8,21 +8,13 @@
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
 if(NOT TARGET Hwloc::hwloc)
-  # compatibility with older CMake versions
-  if(HWLOC_ROOT AND NOT Hwloc_ROOT)
-    set(Hwloc_ROOT
-        ${HWLOC_ROOT}
-        CACHE PATH "Hwloc base directory"
-    )
-    unset(HWLOC_ROOT CACHE)
-  endif()
 
   find_package(PkgConfig QUIET)
   pkg_check_modules(PC_HWLOC QUIET hwloc)
 
   find_path(
     Hwloc_INCLUDE_DIR hwloc.h
-    HINTS ${Hwloc_ROOT}
+    HINTS ${HWLOC_ROOT}
           ENV
           HWLOC_ROOT
           ${HPX_HWLOC_ROOT}
@@ -36,7 +28,7 @@ if(NOT TARGET Hwloc::hwloc)
   find_library(
     Hwloc_LIBRARY
     NAMES libhwloc.so libhwloc.lib hwloc
-    HINTS ${Hwloc_ROOT}
+    HINTS ${HWLOC_ROOT}
           ENV
           HWLOC_ROOT
           ${HPX_Hwloc_ROOT}
@@ -46,17 +38,8 @@ if(NOT TARGET Hwloc::hwloc)
           ${PC_Hwloc_LIBRARY_DIRS}
     PATH_SUFFIXES lib lib64
   )
-
-  # Set Hwloc_ROOT in case the other hints are used
-  if(Hwloc_ROOT)
-    # The call to file is for compatibility with windows paths
-    file(TO_CMAKE_PATH ${Hwloc_ROOT} Hwloc_ROOT)
-  elseif(DEFINED ENV{HWLOC_ROOT})
-    file(TO_CMAKE_PATH $ENV{HWLOC_ROOT} Hwloc_ROOT)
-  else()
-    file(TO_CMAKE_PATH "${Hwloc_INCLUDE_DIR}" Hwloc_INCLUDE_DIR)
-    string(REPLACE "/include" "" Hwloc_ROOT "${Hwloc_INCLUDE_DIR}")
-  endif()
+  # Set Hwloc_ROOT
+  get_filename_component(Hwloc_ROOT ${Hwloc_INCLUDE_DIR} DIRECTORY)
 
   set(Hwloc_LIBRARIES ${Hwloc_LIBRARY})
   set(Hwloc_INCLUDE_DIRS ${Hwloc_INCLUDE_DIR})
@@ -80,7 +63,6 @@ if(NOT TARGET Hwloc::hwloc)
   add_library(Hwloc::hwloc INTERFACE IMPORTED)
   target_include_directories(Hwloc::hwloc SYSTEM INTERFACE ${Hwloc_INCLUDE_DIR})
   target_link_libraries(Hwloc::hwloc INTERFACE ${Hwloc_LIBRARIES})
-  mark_as_advanced(HWLOC_ROOT HWLOC_LIBRARY HWLOC_INCLUDE_DIR)
 
-  mark_as_advanced(Hwloc_ROOT Hwloc_LIBRARY Hwloc_INCLUDE_DIR)
+  mark_as_advanced(Hwloc_LIBRARY Hwloc_INCLUDE_DIR)
 endif()

cmake/FindJemalloc.cmake

@@ -7,21 +7,12 @@
 # Distributed under the Boost Software License, Version 1.0. (See accompanying
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
-# compatibility with older CMake versions
-if(JEMALLOC_ROOT AND NOT Jemalloc_ROOT)
-  set(Jemalloc_ROOT
-      ${JEMALLOC_ROOT}
-      CACHE PATH "Jemalloc base directory"
-  )
-  unset(JEMALLOC_ROOT CACHE)
-endif()
-
 find_package(PkgConfig QUIET)
 pkg_check_modules(PC_JEMALLOC QUIET jemalloc)
 
 find_path(
   Jemalloc_INCLUDE_DIR jemalloc/jemalloc.h
-  HINTS ${Jemalloc_ROOT}
+  HINTS ${JEMALLOC_ROOT}
         ENV
         JEMALLOC_ROOT
         ${HPX_JEMALLOC_ROOT}
@@ -37,7 +28,7 @@ if(MSVC)
   # missing posix headers
   find_path(
     Jemalloc_ADDITIONAL_INCLUDE_DIR msvc_compat/strings.h
-    HINTS ${Jemalloc_ROOT}
+    HINTS ${JEMALLOC_ROOT}
           ENV
           JEMALLOC_ROOT
           ${HPX_JEMALLOC_ROOT}
@@ -49,21 +40,10 @@ if(MSVC)
   )
 endif()
 
-# Set Jemalloc_ROOT in case the other hints are used
-if(Jemalloc_ROOT)
-  # The call to file is for compatibility with windows paths
-  file(TO_CMAKE_PATH ${Jemalloc_ROOT} Jemalloc_ROOT)
-elseif(DEFINED ENV{JEMALLOC_ROOT})
-  file(TO_CMAKE_PATH $ENV{JEMALLOC_ROOT} Jemalloc_ROOT)
-else()
-  file(TO_CMAKE_PATH "${Jemalloc_INCLUDE_DIR}" Jemalloc_INCLUDE_DIR)
-  string(REPLACE "/include" "" Jemalloc_ROOT "${Jemalloc_INCLUDE_DIR}")
-endif()
-
 find_library(
   Jemalloc_LIBRARY
   NAMES jemalloc libjemalloc
-  HINTS ${Jemalloc_ROOT}
+  HINTS ${JEMALLOC_ROOT}
         ENV
         JEMALLOC_ROOT
         ${HPX_JEMALLOC_ROOT}
@@ -74,13 +54,6 @@ find_library(
   PATH_SUFFIXES lib lib64
 )
 
-# Set Jemalloc_ROOT in case the other hints are used
-if(NOT Jemalloc_ROOT AND DEFINED ENV{JEMALLOC_ROOT})
-  set(Jemalloc_ROOT $ENV{JEMALLOC_ROOT})
-elseif(NOT Jemalloc_ROOT)
-  string(REPLACE "/include" "" Jemalloc_ROOT "${Jemalloc_INCLUDE_DIR}")
-endif()
-
 set(Jemalloc_LIBRARIES ${Jemalloc_LIBRARY})
 set(Jemalloc_INCLUDE_DIRS ${Jemalloc_INCLUDE_DIR})
 

cmake/FindLibSigSegv.cmake

@@ -4,23 +4,14 @@
 # Distributed under the Boost Software License, Version 1.0. (See accompanying
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
-# compatibility with older CMake versions
-if(LIBSIGSEGV_ROOT AND NOT Libsigsegv_ROOT)
-  set(Libsigsegv_ROOT
-      ${LIBSIGSEGV_ROOT}
-      CACHE PATH "Libsigsegv base directory"
-  )
-  unset(LIBSIGSEGV_ROOT CACHE)
-endif()
-
 find_package(PkgConfig QUIET)
 pkg_check_modules(PC_LIBSIGSEGV QUIET libsigsegv)
 
 find_path(
   Libsigsegv_INCLUDE_DIR sigsegv.h
-  HINTS ${Libsigsegv_ROOT}
+  HINTS ${LIBSIGSEGV_ROOT}
         ENV
-        Libsigsegv_ROOT
+        LIBSIGSEGV_ROOT
         ${PC_Libsigsegv_MINIMAL_INCLUDEDIR}
         ${PC_Libsigsegv_MINIMAL_INCLUDE_DIRS}
         ${PC_Libsigsegv_INCLUDEDIR}
@@ -31,27 +22,16 @@ find_path(
 find_library(
   Libsigsegv_LIBRARY
   NAMES sigsegv libsigsegv
-  HINTS ${Libsigsegv_ROOT}
+  HINTS ${LIBSIGSEGV_ROOT}
         ENV
-        Libsigsegv_ROOT
+        LIBSIGSEGV_ROOT
         ${PC_Libsigsegv_MINIMAL_LIBDIR}
         ${PC_Libsigsegv_MINIMAL_LIBRARY_DIRS}
         ${PC_Libsigsegv_LIBDIR}
         ${PC_Libsigsegv_LIBRARY_DIRS}
   PATH_SUFFIXES lib lib64
 )
 
-# Set Libsigsegv_ROOT in case the other hints are used
-if(Libsigsegv_ROOT)
-  # The call to file is for compatibility with windows paths
-  file(TO_CMAKE_PATH ${Libsigsegv_ROOT} Libsigsegv_ROOT)
-elseif(DEFINED ENV{LIBSIGSEGV_ROOT})
-  file(TO_CMAKE_PATH $ENV{LIBSIGSEGV_ROOT} Libsigsegv_ROOT)
-else()
-  file(TO_CMAKE_PATH "${Libsigsegv_INCLUDE_DIR}" Libsigsegv_INCLUDE_DIR)
-  string(REPLACE "/include" "" Libsigsegv_ROOT "${Libsigsegv_INCLUDE_DIR}")
-endif()
-
 set(Libsigsegv_LIBRARIES ${Libsigsegv_LIBRARY})
 set(Libsigsegv_INCLUDE_DIRS ${Libsigsegv_INCLUDE_DIR})
 

cmake/FindLibfabric.cmake

@@ -4,51 +4,25 @@
 # Distributed under the Boost Software License, Version 1.0. (See accompanying
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
-# compatibility with older CMake versions
-if(LIBFABRIC_ROOT AND NOT Libfabric_ROOT)
-  set(Libfabric_ROOT
-      ${LIBFABRIC_ROOT}
-      CACHE PATH "Libfabric base directory"
-  )
-  unset(LIBFABRIC_ROOT CACHE)
-endif()
-
 find_package(PkgConfig QUIET)
 pkg_check_modules(PC_LIBFABRIC QUIET libfabric)
 
 find_path(
   Libfabric_INCLUDE_DIR rdma/fabric.h
-  HINTS ${Libfabric_ROOT} ENV LIBFABRIC_ROOT ${Libfabric_DIR} ENV LIBFABRIC_DIR
+  HINTS ${LIBFABRIC_ROOT} ENV LIBFABRIC_ROOT ${Libfabric_DIR} ENV LIBFABRIC_DIR
   PATH_SUFFIXES include
 )
 
 find_library(
   Libfabric_LIBRARY
   NAMES fabric
-  HINTS ${Libfabric_ROOT} ENV LIBFABRIC_ROOT
+  HINTS ${LIBFABRIC_ROOT} ENV LIBFABRIC_ROOT
   PATH_SUFFIXES lib lib64
 )
 
-# Set Libfabric_ROOT in case the other hints are used
-if(Libfabric_ROOT)
-  # The call to file is for compatibility with windows paths
-  file(TO_CMAKE_PATH ${Libfabric_ROOT} Libfabric_ROOT)
-elseif(DEFINED ENV{LIBFABRIC_ROOT})
-  file(TO_CMAKE_PATH $ENV{LIBFABRIC_ROOT} Libfabric_ROOT)
-else()
-  file(TO_CMAKE_PATH "${Libfabric_INCLUDE_DIR}" Libfabric_INCLUDE_DIR)
-  string(REPLACE "/include" "" Libfabric_ROOT "${Libfabric_INCLUDE_DIR}")
-endif()
-
-if(NOT Libfabric_INCLUDE_DIR OR NOT Libfabric_LIBRARY)
-  hpx_error("Could not find Libfabric_INCLUDE_DIR or Libfabric_LIBRARY please \
-  set the Libfabric_ROOT environment variable"
-  )
-endif()
-
 include(FindPackageHandleStandardArgs)
 find_package_handle_standard_args(
   Libfabric DEFAULT_MSG Libfabric_LIBRARY Libfabric_INCLUDE_DIR
 )
 
-mark_as_advanced(Libfabric_ROOT)
+mark_as_advanced(Libfabric_ROOT Libfabric_LIBRARY Libfabric_INCLUDE_DIR)