chore: remove k8s.io replace pins and update script - #316
Merged
Conversation
The replace block and hack/update-kubernetes-library.sh were adapted from chaos-mesh in #207. That pattern is only required for projects that depend on the k8s.io/kubernetes monorepo, whose staging modules are declared as v0.0.0. This project only uses published staging modules plus controller-runtime, so MVS keeps versions aligned on its own. The pins also block dependabot from bumping controller-runtime, because it updates require directives but never replace directives.
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
==========================================
- Coverage 52.98% 47.27% -5.71%
==========================================
Files 12 13 +1
Lines 787 882 +95
==========================================
Hits 417 417
- Misses 349 444 +95
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
STRRL
marked this pull request as ready for review
July 19, 2026 01:05
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 31 k8s.io replace directives in go.mod and
hack/update-kubernetes-library.shwere adapted from chaos-mesh in #207. That pattern is only required for projects that depend on thek8s.io/kubernetesmonorepo, whose staging modules are declared as v0.0.0. This project never depended on it: it only uses published staging modules (k8s.io/api,k8s.io/client-go, etc.) plus controller-runtime, so Go's minimal version selection keeps versions aligned on its own.The pins also permanently block dependabot from bumping controller-runtime (#306 keeps failing to compile), because dependabot updates require directives but never replace directives.
Solution
Remove the replace block and the script. Kubernetes dependency bumps are handled by the dependabot
kubernetesgroup going forward.Major Changes
go get k8s.io/kuberneteswould actually add the whole monorepo as a dependency if ever runVerified locally:
go build ./...andgo test ./pkg/...pass, both on the current master baseline and with controller-runtime 0.24.1 + k8s.io v0.36.0.