Remove keys with null values so that _build_aerleon_definitions fails and path objects are replaced. Added test for edge case with vxlans

Author: Qwiko

src/cnaas_nms/api/settings.py

@@ -36,6 +36,9 @@ def validate_json_to_model(json_data):
             ret_copy = ret.copy()
             ret_copy["system_access_lists"] = list(ret_copy.get("access_lists", {}).keys())
 
+            # Remove any keys without any value
+            ret_copy = {k: v for k, v in ret_copy.items() if v}
+
             # Check if we can build aerleon definitions with the provided settings
             try:
                 _build_aerleon_definitions(ret_copy)

src/cnaas_nms/api/tests/test_settings.py

@@ -103,6 +103,37 @@ def test_access_list_reference_no_data(testclient: FlaskClient):
     assert "No IP addresses found for network: BGP_PEERS" in result.json["message"]
 
 
+def test_access_list_reference_vxlans(testclient: FlaskClient):
+    """Test that reference to vxlans falls back to standard values instead of being empty"""
+    settings_data = {
+        "network_definitions": {
+            "students_gws": [
+                {"path": "vxlans.* | [?vrf=='STUDENT'].[ipv4_gw, ipv4_secondaries, ipv6_gw][][]"},
+            ]
+        },
+        "access_lists": {
+            "ACLTEST": {"terms": [{"name": "allow_bgp", "destination-address": "students_gws", "action": "accept"}]}
+        },
+    }
+
+    result = testclient.post("/api/v1.0/settings/model", json=settings_data)
+    assert result.status_code == 200
+
+
+def test_access_list_invalid_jmespath(testclient: FlaskClient):
+    """Test that invalid jmespath triggers on /settings/model api"""
+    settings_data = {
+        "network_definitions": {
+            "invalid_path": [
+                {"path": "vxlans]"},
+            ]
+        }
+    }
+
+    result = testclient.post("/api/v1.0/settings/model", json=settings_data)
+    assert result.status_code == 400
+
+
 def test_settings_model(testclient: FlaskClient):
     result = testclient.get("/api/v1.0/settings/model")
     assert result.status_code == 200