Fix multiple invocation bug

This bug arose when all of the libraries were consoliated into the same library for better packaging. Each set of classes was being instantiated 3 times as a result.

Author: mnadareski

BinaryObjectScanner/FileType/Executable.cs

@@ -399,10 +399,8 @@ public ConcurrentDictionary<IPortableExecutableCheck, string> RunPortableExecuta
         /// <summary>
         /// Initialize all implementations of a type
         /// </summary>
-        private static IEnumerable<T>? InitCheckClasses<T>()
-            => InitCheckClasses<T>(typeof(GameEngine._DUMMY).Assembly) ?? Enumerable.Empty<T>()
-                .Concat(InitCheckClasses<T>(typeof(Packer._DUMMY).Assembly) ?? Enumerable.Empty<T>())
-                .Concat(InitCheckClasses<T>(typeof(Protection._DUMMY).Assembly) ?? Enumerable.Empty<T>());
+        private static IEnumerable<T>? InitCheckClasses<T>() =>
+            InitCheckClasses<T>(typeof(Handler).Assembly) ?? Enumerable.Empty<T>();
 
         /// <summary>
         /// Initialize all implementations of a type
@@ -412,11 +410,7 @@ public ConcurrentDictionary<IPortableExecutableCheck, string> RunPortableExecuta
             return assembly.GetTypes()?
                 .Where(t => t.IsClass && t.GetInterface(typeof(T).Name) != null)?
                 .Select(t => (T?)Activator.CreateInstance(t))
-#if NET40 || NET452
                 .Cast<T>() ?? [];
-#else
-                .Cast<T>() ?? Array.Empty<T>();
-#endif
         }
 
         #endregion

BinaryObjectScanner/GameEngine/_DUMMY.cs

@@ -171,12 +171,8 @@ public static ConcurrentDictionary<string, ConcurrentQueue<string>> HandlePathCh
         /// <summary>
         /// Initialize all implementations of a type
         /// </summary>
-        private static IEnumerable<T?> InitCheckClasses<T>()
-        {
-            return InitCheckClasses<T>(typeof(GameEngine._DUMMY).Assembly)
-                .Concat(InitCheckClasses<T>(typeof(Packer._DUMMY).Assembly))
-                .Concat(InitCheckClasses<T>(typeof(Protection._DUMMY).Assembly));
-        }
+        private static IEnumerable<T?> InitCheckClasses<T>() =>
+            InitCheckClasses<T>(typeof(Handler).Assembly);
 
         /// <summary>
         /// Initialize all implementations of a type
@@ -185,11 +181,7 @@ public static ConcurrentDictionary<string, ConcurrentQueue<string>> HandlePathCh
         {
             return assembly.GetTypes()?
                 .Where(t => t.IsClass && t.GetInterface(typeof(T).Name) != null)?
-#if NET40 || NET452
                 .Select(t => (T?)Activator.CreateInstance(t)) ?? [];
-#else
-                .Select(t => (T?)Activator.CreateInstance(t)) ?? Array.Empty<T>();
-#endif
         }
 
         #endregion

BinaryObjectScanner/Handler.cs

@@ -146,7 +146,6 @@ internal ConcurrentQueue<string> SafeDiscCheckDirectoryPath(string path, IEnumer
                     new PathMatch("drvmgt.dll", useEndsWith: true),
                     new PathMatch("mcp.dll", useEndsWith: true),
                     new PathMatch("secdrv.sys", useEndsWith: true),
-
                 }, "SafeDisc 1.45.011-1.50.020"),
 
                 // TODO: Research "splash16.bmp" and "splash256.bmp".