v1.1.0 Issues

[jellybean2004]

This is a top-level issue to track the issues discovered on the pre-releases of v1.1.0.

[sara-mokhtari]

Hello everyone,

I tested the alpha version and here's what I observed:

• in the Python interface, all four models (tetrahedron, truncated_tetrahedron, truncated_octahedron, and prism) are working correctly. I was able to fit experimental data of truncated tetrahedrons, non-truncated octahedrons, and pentagonal prisms, and the returned parameters match the expectations.
• in the GUI, only truncated_octahedron (the C + Python model) is working. The three pure Python models (tetrahedron, truncated_tetrahedron, truncated_octahedron) all fail with the same error as before:
  NotImplementedError("Magnetism not implemented for pure python models") NotImplementedError: Magnetism not implemented for pure python models (it is not possible to perform a fitting at all)
• Also there is some documentation issues, probably not hard to fix (formulas overflowing on the right, images that are too large, one wrong legend in a graph).

I should have asked this before but I'm not sure I've understood how to fix the issues during this freeze period (I mean the process, do we have to make new PR ?). But if I can do something, I would totally be down to fix the documentation issues. Neverthelesss, I would not be able to help with the "magnetism" error.

Thank you in advance !

[jellybean2004]

Hi @sara-mokhtari,

Thank you for your detailed comments and review!

If you could create a sub-issue here for the problems you found, and label it with Sasmodels 1.1.0 that will be easier for us to track. I have done so for one of the issues you mentioned.

Yes, any bug/doc fixes should be put in as a PR. Please create a sub-issue describing the things you are fixing, and link it with your PR fixing that. I will add it to the release branch after it gets approved.

Let me know if you need any help.