fix(publisheddata): return the correct format for publisher in v3

[fpotier]

Description

V3 api should return "publisher": "string" not "publisher: { "name": "string" }

Motivation

Fixes

Changes:

• fix publisher property in reponse
• use class-transformer for serialization of the reponse

Tests included

• Included for each change/fix?
• Passing?

Documentation

• swagger documentation updated (required for API changes)
• official documentation updated

official documentation info

[minottic]

are there tests anywhere (either unit or mocha) that check the transformations?

[minottic]

I have a bit the impression tests are missing, at least for the bug fix, I expected to see a test now.

For what concerns the refactor, that looks very nice IMO! Was this mapping ever tested, even before your refactor?

[fpotier]

I have a bit the impression tests are missing, at least for the bug fix, I expected to see a test now.

For what concerns the refactor, that looks very nice IMO! Was this mapping ever tested, even before your refactor?

tests for the mapping were not really existing, my last commit adds some

[fpotier]

this also fixes a bug where publicationYear would always be overwritten with the current year

[minottic]

I think the tests from 8358def are great, but since they also required a bunch of bug fixes, would it make sense to move that commit to a dedicated PR (if cherry-picking the commit into master is not too conflict prone)? then we limit this to a refactor and the git history will look cleaner.

[minottic]

I think the tests from 8358def are great, but since they also required a bunch of bug fixes, would it make sense to move that commit to a dedicated PR (if cherry-picking the commit into master is not too conflict prone)? then we limit this to a refactor and the git history will look cleaner.

actually forget this, I missed before that this PR already contains bug fixes, and it's not only a refactor.

Maybe it's worth though to open an issue to refactor the convertObsoleteToCurrent in the same way leveraging DTOs