chore(deps): run npm audit fix #2399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we have most non-breaking security fixes in package-lock.json. Change-Id: Ie2e485a05784d118d434bb92e33906b10b73da5d
fpotier
approved these changes
Dec 5, 2025
nitrosx
reviewed
Dec 5, 2025
Member
nitrosx
left a comment
nitrosx
left a comment
There was a problem hiding this comment.
@bpedersen2: I am wondering if we need to commit the package-lock.json to the repo or we should advice the users to to run an update with npm?
Member
|
I forget to say that I trust your judgment and my comment is not blocking if you say that we need this PR. |
Junjiequan
approved these changes
Dec 5, 2025
Member
the lock file is intended to be comitted |
sbliven
approved these changes
Dec 5, 2025
Member
|
It's good to run this regularly. I'm surprised that dependabot didn't update these automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we have most non-breaking security fixes in package-lock.json.