-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MTK structure indexing tests #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests don't run because Direct
isn't defined. They're very comprehensive, but I think ReactionSystem
might need to implement SII for this to work.
Good catch. Practically this will need the latest MTK update to run (and the accompanying PRs), as that (should) fix a lot of the issues, and also enable the Ideally also #735 to make it easier to test the observables. |
Also, are you sure about |
|
4b9cbda
to
5fc9e0f
Compare
ed9d673
to
1a0576c
Compare
b2cf4ba
to
b257356
Compare
8d2dabe
to
bf7bb43
Compare
Closed due to git history mess |
Adds a range of tests that should cover all cases of indexing for all relevant problem types. Will need to wait for merging until various fixes in SymbolicIndexingInterface, as well as updated support for indexing parameters via
.ps[]
notation.