Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation.yaml #2

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Update Documentation.yaml #2

merged 2 commits into from
Dec 4, 2024

Conversation

isaacsas
Copy link
Member

This is just what Catalyst uses. It adds a lot of stuff for GLMakie support that probably isn't needed, however, it works quite well and allows us to preview the build by downloading the artifact before merging.

@isaacsas isaacsas closed this Nov 13, 2024
@isaacsas isaacsas reopened this Nov 13, 2024
@isaacsas isaacsas closed this Nov 13, 2024
@isaacsas isaacsas reopened this Nov 13, 2024
@isaacsas
Copy link
Member Author

@vyudu your CI is failing it seems. Looks like a missing dependency. Do you really need an explicit dependency on UnPack?

@isaacsas
Copy link
Member Author

isaacsas commented Nov 13, 2024

Ahh I see. You need to add everything that you using in any test script as both an extra and as a target in the Project.toml.

@isaacsas
Copy link
Member Author

(Assuming it isn't already a dep with a compat entry that is.)

@isaacsas isaacsas closed this Nov 13, 2024
@isaacsas isaacsas reopened this Nov 13, 2024
@vyudu
Copy link
Member

vyudu commented Nov 15, 2024

NTS: bump satisfiability when available

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12167930952

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.915%

Totals Coverage Status
Change from base Build 12167892920: 0.0%
Covered Lines: 470
Relevant Lines: 682

💛 - Coveralls

@vyudu vyudu merged commit 4b89cfb into main Dec 4, 2024
2 checks passed
@isaacsas isaacsas deleted the isaacsas-update-doc-ci branch December 4, 2024 21:33
@isaacsas isaacsas restored the isaacsas-update-doc-ci branch December 4, 2024 21:35
@isaacsas
Copy link
Member Author

isaacsas commented Dec 4, 2024

Wait, did you actually merge anything or did you remove all the PR code?

@vyudu
Copy link
Member

vyudu commented Dec 4, 2024

Oh hmm, that's weird. It does seem like the documentation.yaml got updated correctly though?

@vyudu
Copy link
Member

vyudu commented Dec 4, 2024

Ah, it's saying nothing changed because apparently I merged these changes into my local branch already a couple of days ago, then I merged my local main into this remote branch. I think I probably just messed up the direction of my merge for the first one.

@isaacsas
Copy link
Member Author

isaacsas commented Dec 4, 2024

Got it.

@isaacsas isaacsas deleted the isaacsas-update-doc-ci branch December 4, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants