Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document use of Distributions with eFAST #163

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

scheidan
Copy link
Contributor

Documents the possibility to use Distributions to define input ranges for eFAST. This was enabled with by
#133

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Documents the use of `Distributions` enabled by:
SciML#133
@ChrisRackauckas
Copy link
Member

Should it be a separate example?

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (58f0c5e) to head (b850cd0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   93.01%   92.28%   -0.73%     
==========================================
  Files          11       11              
  Lines         830      830              
==========================================
- Hits          772      766       -6     
- Misses         58       64       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02
Copy link
Member

A separate example might be nice if @scheidan can put one together, otherwise, this looks fine as well since it clearly demonstrates the use of distributions different from the ranges (and this is just the docstring)

@Vaibhavdixit02 Vaibhavdixit02 merged commit 2e51545 into SciML:master Apr 18, 2024
9 of 12 checks passed
@scheidan scheidan deleted the patch-1 branch April 19, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants