Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage check isn't working #22

Closed
nicholaskl97 opened this issue Mar 26, 2024 · 5 comments
Closed

Code coverage check isn't working #22

nicholaskl97 opened this issue Mar 26, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@nicholaskl97
Copy link
Collaborator

Describe the bug 🐞

Codecov isn't generating new reports, for some reason. It hasn't for a month.
@nicholaskl97 nicholaskl97 added the bug Something isn't working label Mar 26, 2024
@nicholaskl97
Copy link
Collaborator Author

The last commit to generate a Codecov report was merging #16.

It might have to do with #17, which was a change to the CI workflow, intended to stop failures on nightly from registering as failed tests, since that was the first to fail.

@nicholaskl97
Copy link
Collaborator Author

Alternatively, looking at CI logs, "Error: Codecov token not found. Please provide Codecov token with -t flag." could be the issue.

@ChrisRackauckas
Copy link
Member

It needs to be fixed with a token. @thazhemadam

@thazhemadam
Copy link
Member

Fixed by #23.

@nicholaskl97
Copy link
Collaborator Author

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChrisRackauckas @nicholaskl97 @thazhemadam