Incorporate Muller into test suite

Add `left` and `right` fields to solution

Author: fgittins

lib/BracketingNonlinearSolve/src/BracketingNonlinearSolve.jl

@@ -45,6 +45,6 @@ end
 
 @reexport using SciMLBase, NonlinearSolveBase
 
-export Alefeld, Bisection, Brent, Falsi, Muller, ITP, Ridder
+export Alefeld, Bisection, Brent, Falsi, ITP, Muller, Ridder
 
 end

lib/BracketingNonlinearSolve/src/muller.jl

@@ -43,13 +43,15 @@ function CommonSolve.solve(prob::IntervalNonlinearProblem, alg::Muller, args...;
         # Termination Check
         if abstol ≥ abs(fxᵢ₊₁)
             return SciMLBase.build_solution(prob, alg, xᵢ₊₁, fxᵢ₊₁;
-                                            retcode = ReturnCode.Success)
+                                            retcode = ReturnCode.Success,
+                                            left = xᵢ₊₁, right = xᵢ₊₁)
         end
 
         xᵢ₋₂, xᵢ₋₁, xᵢ = xᵢ₋₁, xᵢ, xᵢ₊₁
         fxᵢ₋₂, fxᵢ₋₁, fxᵢ = fxᵢ₋₁, fxᵢ, fxᵢ₊₁
     end
 
     return SciMLBase.build_solution(prob, alg, xᵢ₊₁, fxᵢ₊₁;
-                                    retcode = ReturnCode.MaxIters)
+                                    retcode = ReturnCode.MaxIters,
+                                    left = xᵢ₊₁, right = xᵢ₊₁)
 end

lib/BracketingNonlinearSolve/test/rootfind_tests.jl

@@ -7,7 +7,7 @@ end
 @testitem "Interval Nonlinear Problems" setup=[RootfindingTestSnippet] tags=[:core] begin
     using ForwardDiff
 
-    @testset for alg in (Bisection(), Falsi(), Ridder(), Brent(), ITP(), Alefeld(), nothing)
+    @testset for alg in (Alefeld(), Bisection(), Brent(), Falsi(), ITP(), Muller(), Ridder(), nothing)
         tspan = (1.0, 20.0)
 
         function g(p)
@@ -52,7 +52,7 @@ end
     prob = IntervalNonlinearProblem(quadratic_f, (1.0, 20.0), 2.0)
     ϵ = eps(Float64) # least possible tol for all methods
 
-    @testset for alg in (Bisection(), Falsi(), ITP(), nothing)
+    @testset for alg in (Bisection(), Falsi(), ITP(), Muller(), nothing)
         @testset for abstol in [0.1, 0.01, 0.001, 0.0001, 1e-5, 1e-6]
             sol = solve(prob, alg; abstol)
             result_tol = abs(sol.u - sqrt(2))
@@ -62,7 +62,7 @@ end
         end
     end
 
-    @testset for alg in (Ridder(), Brent())
+    @testset for alg in (Brent(), Ridder())
         # Ridder and Brent converge rapidly so as we lower tolerance below 0.01, it
         # converges with max precision to the solution
         @testset for abstol in [0.1]
@@ -76,7 +76,7 @@ end
 end
 
 @testitem "Flipped Signs and Reversed Tspan" setup=[RootfindingTestSnippet] tags=[:core] begin
-    @testset for alg in (Alefeld(), Bisection(), Falsi(), Brent(), ITP(), Ridder(), nothing)
+    @testset for alg in (Alefeld(), Bisection(), Brent(), Falsi(), ITP(), Muller(), Ridder(), nothing)
         f1(u, p) = u * u - p
         f2(u, p) = p - u * u