Skip to content

Aitken-Neville uses wrong controller #3029

@termi-official

Description

@termi-official

Describe the example

When refactoring the controller interface I noticed that Aitken-Neville uses a PI controller instead of a custom extrapolation controller. IIUC this is not correct, as changing the coefficients in this controller class permanently yields sub-optimal control performance. It seems that it was missed in one of the previous updates of the sublibrary, as the error estimation part in perform step looks differently that the implementation of all other extrapolation algorithms (c.f.

dtpropose = step_accept_controller!(
integrator, alg,
stepsize_controller!(integrator, alg)
)
).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions