Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let each numerator have its own denominator #385

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

sumiya11
Copy link
Collaborator

May be useful for Gleb.
I did not see a speedup because I could not find models where GB is a bottleneck.
Do not merge.

--Sasha

@pogudingleb
Copy link
Collaborator

Thanks, Sasha !
As discussed elsewhere, we can take this idea further and have the same number of numerators and denominators. This would at least simplify the MQS logic. Just pushed this update

@pogudingleb pogudingleb merged commit 4349381 into master Feb 13, 2025
10 checks passed
@pogudingleb pogudingleb deleted the small-unimportant-fix branch February 13, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants